Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] account_sepa: EPC QR code on supplier payment #29612

Open
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@william-andre
Copy link
Contributor

william-andre commented Dec 18, 2018

/!\ This is only used so that runbot can merge on enterprise. The enterprise branch is compliant with OPW 1906794

In Europe, there is the EPC QR Code that can be used to record a payment with mobile apps. In the wizard to record
a payment to a supplier, we should have the ability to show the EPC QR Code. That way, the user can scan it on the
screen with his mobile and pay right away.

Add a setting to activate the option
Add the img on the view
OPW 1918423

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Dec 18, 2018

@C3POdoo C3POdoo added the OE label Dec 18, 2018

@robodoo robodoo added the CI 🤖 label Dec 18, 2018

@qdp-odoo qdp-odoo force-pushed the odoo-dev:master-qrcode-supplier-payment-wan branch to eb2f28b Feb 20, 2019

@robodoo robodoo removed the CI 🤖 label Feb 20, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 5, 2019

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

qdp-odoo commented Mar 7, 2019

@william-andre It would be cool to read your diff before greening the task, to make sure it's ready. I can see here and there TODO, FIXME, commented code, comments that shouldn't be here....

While reading it I can't be certain you would yourself evaluate it as ready-to-be-reviewed :-s

@william-andre

This comment has been minimized.

Copy link
Contributor Author

william-andre commented Mar 8, 2019

@qdp-odoo The FIXME was there before, I didn't look into it. The TODO's are only small details that I will look when doing a last pass on the code.

I put the task in green because I needed to know if you were ok with the way the refactoring was made.
Note that the last commit is an attempt to make a better separation of the multi thing, but it may be more complicated than necessary.

@robodoo robodoo removed the CI 🤖 label Mar 13, 2019

@william-andre william-andre force-pushed the odoo-dev:master-qrcode-supplier-payment-wan branch 4 times, most recently from 528d752 to 10ec467 Mar 13, 2019

@william-andre william-andre force-pushed the odoo-dev:master-qrcode-supplier-payment-wan branch from 10ec467 to cc765e7 Mar 20, 2019

qdp-odoo and others added some commits Feb 20, 2019

[IMP] account: small rework of payments
group_invoices option now behaves as expected: group payments group as much as possible, otherwise doesn't group at all
partner_bank_account_id not required as soon as visible (depends on the payment method)
refactoring to name <group> tags and allow easier inheritance via xpath

part of task #1918423

@william-andre william-andre force-pushed the odoo-dev:master-qrcode-supplier-payment-wan branch from cc765e7 to cd6c71d Mar 20, 2019

t

@william-andre william-andre force-pushed the odoo-dev:master-qrcode-supplier-payment-wan branch from cd6c71d to a3de098 Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.