Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail js ref #29617

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@alexkuhn
Copy link
Contributor

alexkuhn commented Dec 18, 2018

Task-ID 1914207

@C3POdoo C3POdoo added the RD label Dec 18, 2018

@alexkuhn alexkuhn added the Services label Dec 18, 2018

@robodoo robodoo removed the CI 🤖 label Dec 18, 2018

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Dec 18, 2018

@robodoo robodoo added the CI 🤖 label Dec 18, 2018

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Dec 19, 2018

@robodoo robodoo removed the CI 🤖 label Dec 19, 2018

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Dec 20, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 20, 2018

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Dec 20, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 20, 2018

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Dec 21, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 21, 2018

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Dec 26, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 26, 2018

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Dec 26, 2018

@robodoo robodoo added the CI 🤖 label Dec 26, 2018

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Dec 26, 2018

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 26, 2018

@robodoo robodoo removed the CI 🤖 label Feb 20, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch 2 times, most recently Feb 21, 2019

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Feb 28, 2019

@robodoo robodoo removed the CI 🤖 label Feb 28, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Feb 28, 2019

@robodoo robodoo added the CI 🤖 label Feb 28, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Mar 1, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 1, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Mar 5, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 5, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Mar 6, 2019

@robodoo robodoo removed the CI 🤖 label Mar 6, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Mar 8, 2019

@robodoo robodoo added the CI 🤖 label Mar 8, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch Mar 12, 2019

@robodoo robodoo removed the CI 🤖 label Mar 12, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch 5 times, most recently from 83d6b4f to 698516f Mar 12, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch 2 times, most recently from b950cd4 to b96466d Mar 21, 2019

alexkuhn added some commits Feb 12, 2019

wip
<!!> Todo:
- remove dumb reliance on jquery for messaging composite components
  and add composite component once in DOM
  => huge performance issue atm

--- WIP (13) ---

Todo:
- make (wip) versions of thread windows

==== OLD LOGS ====

--- WIP (12) ---

Todo:
- restore disabled feature(s) from this PR: #29974

--- WIP (11) ---

In progress:
- component-based architecture for messaging apps

Todo:
- be able to freeze re-ordering of ordered list
composite component, such as when renaming a conversation.

--- WIP (10) ---

Todo:
- discuss content redesign
	- messages (squashed/unsquashed versions) + date separator
	- load more messages on scroll
- discuss control panel redesign
- others:
   1. mass-mailing icon in the sidebar
   2. livechat in sidebar (to be done with readapt of messaging_manager_livechat)
   3. im_support channel in sidebar (to be done with readapt of messaging_manager_support)
   4. snailmail message (to be done with readapt of messaging_manager_snailmail)

Known issues:
- Some UI caused by brute-force re-rendering:
	1. input re-rendered (hack helps keep text + selection, but it cancels composition mode...)
	2. click on '+' of channel then '+' of dm_chat does not work due to re-render when blur on add channel input
	   (this is also the case with commands next to message)
	3. each re-render autoscroll on top
	4. Does not support CSS animations/transitions
  > Note that all the issues above could be solved with smart rendering

Done:
- rendering of mailboxes, channels, dm_chats in sidebar
- dm_chat and channel counters (unread & needaction) and commands (settings & leave)
- add channel/dm_chat/rename conversation inputs with save state on re-rendering
- basic

--- WIP (9) ---

Todo:
- continue rendering of discuss sidebar
- restore all features of discuss (temporarily all removed)

Known issues:
- broken messaging menu item style
- broken chat window interactions (e.g. fold/close/server-sync)

--- WIP (8) ---

- <!!!> [TEMP] iap temporarily disabled auto-install

We should adapt snailmail to mail refactoring before re-enabling it.

--- WIP (7) ---

wip several improvements, should look at init/start model of component/sub-components...

--- WIP (6) ---

TODO:

- since thread.xml now uses `widget.` most of the time,
thread window and other parts are broken because they rely
on old template args (e.g. `thread`, `messages`, etc.)

- flatten thread windows, removed abstract widget
- thread window cleaning
- <!!!!!> removed scrolltop feature in discuss
- thread renderer cleaning

--- WIP (5) ---

todo:
 - fold state not updated on thread window
 (different thread object stored by thread window)
 => should use new thread object from updated messaging store

known issue:
 - discuss rendering is slow due to lots of update & render from messaging changes
 => future improvement with smart rendering relying on diff

--- WIP (4) ---

discuss refactoring

<!!!!!!> temporarily removed features:
	- disabled style of control panel buttons

--- WIP (3) ---

1. new messaging menu (incomplete)

- only multi-user-channel and dms are supported
- previews are not sorted correctly
- click on preview is not working
- click on mark as read preview is not working

2. reintroduced messaging models
- albeit simple objects

--- WIP (2) ---

done:
- reworked messaging `isReady`
- remove message from thread(s) handled by messaging manager
- threads and messages are stored in dictionnary with key as their ids
- messaging store in messaging service
- no longer multi_user_channel, dm_chat, mailbox, livechat, support_channel classes
- <!!!!!> [TEMP] removed fadeout effect of removed messages in discuss
- removed message classes
- messaging mixin

wip:
- manager makes immutable changes to the msg store
- make messaging-dependent component passive components (always render on any changes)

todo:
- isolate messaging window manager

--- WIP (1) ---

- clean bundles
- organize discuss structurally
- rename mail_service to messaging_service
- rename mail bus to messaging bus
- flatten thread models + remove abstract ones
- rename thread_widget to thread_renderer
- clean thread & message models
	- improve thread model instantiation parameters
	- thread name as public attribute
	- isFolded as public attribute
	- simplify autowitch logic
	- isDetached as public attribute
	- renamed detached to minimized js side
		- matches server-side definition of thread with open chat window
	- simplify fold state
	- isTwoUserThread as public attribute
- new messaging service includes: Thread, ThreadMessages and ThreadUnread
	- moved some model logic to messaging service (e.g. fetch, post messages)
- global messaging store, available to all messaging components
- rename MessagingService to MessagingManager
- [TEMP] command/event architecture with messaging_service
- [WIP] turn command/event with do_action/notify_changes and on_action/on_changes
- split systray xml
- unsubscribe handled by manager
- mark as read handled by manager
- toggle star status handled by manager
- compact some messaging manager LOCs for readability
- remove thread mixins
	- channel seen mixin
	- thread typing mixin
	- adapt tests with members already fetched
	- simplify members format (including seen and typing features)
wip ref store into dispatch(action)/commit(mutation)
[TEMP] removal of "is typing" & "seen" features
[TEMP] (in progress) removal of "moderation" feature

@alexkuhn alexkuhn force-pushed the odoo-dev:master-mail-aku branch from b96466d to 47aeb20 Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.