Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP]web: pie, bar and line chart tooltip information improvements #29747

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@jso-odoo
Copy link
Contributor

jso-odoo commented Dec 26, 2018

Description of the issue/feature this PR addresses:

Current behavior before PR:

  • Tooltip information was not meaningful in bar, line and pie chart.

Desired behavior after PR is merged:

  • Added custom template which is the same as given by the library nvD3 for the tooltip which will show the measure of the chart on the top of the tooltip in both normal and comparision view.
    Tooltip data(Measure) will be changed according to the
    measure of the graph and data will be accordingly to the applied groupby fields.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Dec 26, 2018

@jso-odoo jso-odoo changed the title [IMP]web: tooltip information improvements. [IMP]web: pie, bar and line chart tooltip information improvements. Dec 26, 2018

@jso-odoo jso-odoo changed the title [IMP]web: pie, bar and line chart tooltip information improvements. [IMP]web: pie, bar and line chart tooltip information improvements Dec 26, 2018

@C3POdoo C3POdoo added the RD label Dec 26, 2018

@msh-odoo msh-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 2, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 2, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 8, 2019

@robodoo robodoo removed the CI 🤖 label Jan 8, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 8, 2019

@robodoo robodoo added the CI 🤖 label Jan 8, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 8, 2019

@robodoo robodoo removed the CI 🤖 label Jan 8, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 8, 2019

@robodoo robodoo added the CI 🤖 label Jan 8, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 18, 2019

@robodoo robodoo removed the CI 🤖 label Jan 18, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 18, 2019

@robodoo robodoo added the CI 🤖 label Jan 18, 2019

@msh-odoo msh-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 25, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 25, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 28, 2019

@robodoo robodoo removed the CI 🤖 label Jan 28, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-graph-legends-jso branch Jan 28, 2019

@Polymorphe57 Polymorphe57 force-pushed the odoo-dev:master-graph-legends-jso branch 2 times, most recently Feb 21, 2019

@aab-odoo
Copy link
Contributor

aab-odoo left a comment

Besides my remark it's looking good

addons/web/static/src/js/views/graph/graph_renderer.js Outdated
this.timeRangeDescription = undefined;
this.comparisonTimeRangeDescription = undefined;
}
}

This comment has been minimized.

@aab-odoo

aab-odoo Feb 21, 2019

Contributor

i'd move all this to the model directly, and store the description info into the state (alongside other timerange info)

@Polymorphe57 Polymorphe57 force-pushed the odoo-dev:master-graph-legends-jso branch 2 times, most recently Feb 21, 2019

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Feb 22, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 22, 2019

[IMP] web: graph view legend and tooltips improvements
This commit ameliorates the tooltips and the legend
of the graph view in its different modes (bar, line, and pie).

Related task id: 1917940

Co-authored-by: Mohammed Shekha <msh@openerp.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>

closes #29747
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 22, 2019

Staging failed: timed out (>120 minutes)

[IMP] web: graph view legend and tooltips improvements
This commit ameliorates the tooltips and the legend
of the graph view in its different modes (bar, line, and pie).

Related task id: 1917940

Co-authored-by: Mohammed Shekha <msh@openerp.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>

@Polymorphe57 Polymorphe57 force-pushed the odoo-dev:master-graph-legends-jso branch to 9ae9152 Feb 25, 2019

@Polymorphe57

This comment has been minimized.

Copy link
Contributor

Polymorphe57 commented Feb 25, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 25, 2019

I'm sorry, @Polymorphe57. I'm afraid I can't do that.

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Feb 25, 2019

robodoo retry

robodoo pushed a commit that referenced this pull request Feb 25, 2019

[IMP] web: graph view legend and tooltips improvements
This commit ameliorates the tooltips and the legend
of the graph view in its different modes (bar, line, and pie).

Related task id: 1917940

Co-authored-by: Mohammed Shekha <msh@openerp.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>

closes #29747
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 25, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.