Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard navigation issues, wip #29929

Open
wants to merge 14 commits into
base: 12.0
from

Conversation

Projects
None yet
4 participants

@C3POdoo C3POdoo added the RD label Jan 4, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 4, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 16, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 1, 2019

@pka-odoo pka-odoo force-pushed the odoo-dev:12.0-keyboard-navigation-issues-msh branch Feb 13, 2019

@robodoo robodoo removed the CI 🤖 label Feb 13, 2019

@pka-odoo pka-odoo force-pushed the odoo-dev:12.0-keyboard-navigation-issues-msh branch 3 times, most recently Feb 14, 2019

@pka-odoo pka-odoo force-pushed the odoo-dev:12.0-keyboard-navigation-issues-msh branch Feb 22, 2019

msh-odoo and others added some commits Jan 4, 2019

[FIX]web: Fix keyboard navigation issues, wip
Co-authored-by: Tejash Shahu <tsh@odoo.com>
[FIX]web: Keyboard navigation: listview row not selected with down ke…
…y when listview is editable, also pressing enter should make row editable
[FIX]web: Set last active field when dialog is closed,
scenario not working currently: press tab on any active m2o field which will move user to next active field and now use shift + tab and, which will move user back to previous m2o field and now open dialog from m2o and then close it, focus is set to next field of after m2o while expected result is, focus should set back to m2o field itself

Solution: maintain lastActivatedFieldIndex even in shift + tab handler i.e. _activatePreviousFieldWidget so that when focusLastActivatedWidget is called on dialog close then it sets focus on right last active field
[IMP]web: When shift +tab pressed on Save button then set focus back …
…to last widget, to allow user to go back from save button
[FIX]web: Set focus back to o2m 'Add a line' link when o2m dialog is …
…closed either through 'Discard' button or 'Save & Close' button

Current Situation: When o2m has form dialog instead of editable list in that case when dialog is closed using 'Save & Discard' focus does not come back to form controller and due to which navigation gets broke

The reason focus not set is: _focusOnClose function of FormDialog is called before o2m re-render(o2m will be re-render on new value set), also _focusOnClose should be called after modal dialog is hidden, so here hide the modal then set focus back to o2m and then destroy dialog
[IMP]web: added test case for focus on same field
- Pressing Create and Edit option in m2o and when form popup is opened press Escape, it should keep focus on same field.

issue: 1880688
[IMP]mail: added test case for focus on searchview
- added test case for focus should be on search view input in discuss app for unified behaviour

issue: 1880688
[IMP]web: added test case for editable listview
- In editable list view, at the time of creation Press Escape, focus should set on searchbox input.

issue: 1880688
[IMP]web: press enter should open edit mode
- When any row of the editable listview is selected and user press Enter then record should go in edit mode

 task :1880688
[IMP]web: test case for last active widget.
- 'shift+tab' should set focus on last active widget

issue: 1880688
[IMP]web: test case for o2m line focus
- when finish record creation through o2m popup for o2m line and press Save and Close then focus does not come back to form view

issue: 1880688
[IMP]web: test case for moving down
- down key in listview should work with editable listview

issue: 1880688

@msh-odoo msh-odoo force-pushed the odoo-dev:12.0-keyboard-navigation-issues-msh branch to 9e95385 Feb 22, 2019

@robodoo robodoo added the CI 🤖 label Feb 22, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.