[FIX] website_slides: fix various UI issues with comments/likes #30027
Conversation
| @@ -462,7 +462,7 @@ | |||
| tabindex="0" | |||
| data-toggle="popover"> | |||
| <i class="fa fa-thumbs-up fa-1x" role="img" aria-label="Likes" title="Likes"/> | |||
| <t t-esc="slide.likes"/> | |||
| <span class="o_wslides_like_dislike_count" t-esc="slide.likes"/> | |||
There was a problem hiding this comment.
According to my secret informant in the website office, the new name convention for classes is something like:
- o (for le Odoo)
- w (for le website)
- slides (for le module)
He gave me the following example: o_wevent_registration_list
awa-odoo
force-pushed
the
12.0-fix-website-slide-awa
branch
from
762006d
to
5395242
Compare
awa-odoo
changed the title
|
@robodoo r+ |
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
|
I'm sorry, @tde-banana-odoo. This PR is already reviewed, reviewing it again is useless. |
|
@robodoo r+ retry redo do stufff please I am alone in the drak don't try to ff vive les frites |
|
I'm sorry, @tde-banana-odoo. Retry makes no sense when the PR is not in error. This PR is already reviewed, reviewing it again is useless. |
|
@robodoo retry |
|
I'm sorry, @tde-banana-odoo. Retry makes no sense when the PR is not in error. |
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
|
I'm sorry, @tde-banana-odoo. This PR is already reviewed, reviewing it again is useless. |
Task #1923443 Purpose ======= Probably due to the migration to bootstrap 4, the active tab panel in the 'slide_detail_view' was not displayed on page loading (and only when switching back and forth in the tabs). partly closes odoo#29901
Task #1923443 Purpose ======= When adding a like/dislike to a slide, the like/dislike counter was not properly updated. partly closes odoo#29901
awa-odoo
force-pushed
the
12.0-fix-website-slide-awa
branch
from
5395242
to
92e943d
Compare
|
@robodoo retry |
|
I'm sorry, @awa-odoo. Retry makes no sense when the PR is not in error. |
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
|
Merged, thanks! |
Task #1923443
Purpose
This commit fixes several problems with the website UI of the slides module:
Probably due to the migration to bootstrap 4, the active tab panel in the 'slide_detail_view' was not displayed on page loading (and only when switching back and forth in the tabs).
When adding a like/dislike to a slide, the like/dislike counter was not properly updated.
closes #29901