Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE][FIX] mass_mailing: improve statistics use in mass mailing #30059

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@tde-banana-odoo
Copy link
Contributor

commented Jan 9, 2019

Purpose of this merge is to improve the daily use of mass mailing by improving
the way statistics are computed and displayed.

See enterprise PR odoo/enterprise#3391 for marketing automation counterpart
of this merge.

This merge is linked to task ID 1924711 and closes PR #30059.

@robodoo robodoo added the seen 🙂 label Jan 9, 2019

@C3POdoo C3POdoo added the RD label Jan 9, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch Jan 9, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 9, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch Jan 10, 2019

@robodoo robodoo removed the CI 🤖 label Jan 10, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch Jan 10, 2019

@tde-banana-odoo tde-banana-odoo changed the title [MERGE][FIX] mass_mailing: improve statistics computation [MERGE][FIX] mass_mailing: improve statistics use in mass mailing Jan 10, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 10, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch Jan 10, 2019

@robodoo robodoo added the CI 🤖 label Jan 10, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch Jan 31, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 31, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch Feb 12, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 12, 2019

@jem-odoo

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

LGTMamadou.
Fix seems legit.

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch to 3b5e163 Feb 12, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[IMP] link_tracker, mass_mailing: improve link tracker / click and ma…
…il statistic views

Purpose is to have more information available in list and form views. As
trying to access those models is a technical move let us give users all
necessary information to understand / debug a bit what happens.

Concerning links we add necessary view type and fields to ease understanding
of tracking data. Notably in mass mailing mailing related information is added
for clicks.

This commit is linked to task ID 1924711 and PR odoo#30059.

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[FIX] mass_mailing: fix statistic state computation
Replied / Bounced / Opened states should be computed prior to Sent state.
Indeed Sent is the default state once the email is sent. Then replied,
bounced and opened are states that happen after sending the email. It
is therefore necessary to re-order the state computation to correctly compute
the statistic state.

This commit is linked to task ID 1924711 and PR odoo#30059.

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 12, 2019

@dbeguin

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

Nice one ! :)
Make Mass Mailing great again !

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch from 73357d6 to 262d6e3 Apr 8, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 8, 2019

[IMP] link_tracker, mass_mailing: improve link tracker / click and ma…
…il statistic views

Purpose is to have more information available in list and form views. As
trying to access those models is a technical move let us give users all
necessary information to understand / debug a bit what happens.

Concerning links we add necessary view type and fields to ease understanding
of tracking data. Notably in mass mailing mailing related information is added
for clicks.

This commit is linked to task ID 1924711 and PR odoo#30059.

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 8, 2019

[FIX] mass_mailing: fix statistic state computation
Replied / Bounced / Opened states should be computed prior to Sent state.
Indeed Sent is the default state once the email is sent. Then replied,
bounced and opened are states that happen after sending the email. It
is therefore necessary to re-order the state computation to correctly compute
the statistic state.

This commit is linked to task ID 1924711 and PR odoo#30059.

@robodoo robodoo removed the CI 🤖 label Apr 8, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 8, 2019

[FIX] mass_mailing: fix statistic state computation
Replied / Bounced / Opened states should be computed prior to Sent state.
Indeed Sent is the default state once the email is sent. Then replied,
bounced and opened are states that happen after sending the email. It
is therefore necessary to re-order the state computation to correctly compute
the statistic state.

This commit is linked to task ID 1924711 and PR odoo#30059.

@robodoo robodoo added the CI 🤖 label Apr 8, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch from 262d6e3 to 6e589fc Apr 12, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 12, 2019

[IMP] link_tracker, mass_mailing: improve link tracker / click and ma…
…il statistic views

Purpose is to have more information available in list and form views. As
trying to access those models is a technical move let us give users all
necessary information to understand / debug a bit what happens.

Concerning links we add necessary view type and fields to ease understanding
of tracking data. Notably in mass mailing mailing related information is added
for clicks.

This commit is linked to task ID 1924711 and PR odoo#30059.

@robodoo robodoo removed the CI 🤖 label Apr 12, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch from 6e589fc to 8fa4a6a Apr 15, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 15, 2019

[IMP] link_tracker, mass_mailing: improve link tracker, click and mai…
…l statistic views

Purpose is to have more information available in list and form views. As
trying to access those models is a technical move let us give users all
necessary information to understand / debug a bit what happens.

Concerning links we add necessary view type and fields to ease understanding
of tracking data. Notably in mass mailing mailing related information is added
for clicks.

This commit is linked to task ID 1924711 and PR odoo#30059.
[IMP] link_tracker, mass_mailing: improve link tracker, click and mai…
…l statistic views

Purpose is to have more information available in list and form views. As
trying to access those models is a technical move let us give users all
necessary information to understand / debug a bit what happens.

Concerning links we add necessary view type and fields to ease understanding
of tracking data. Notably in mass mailing mailing related information is added
for clicks.

This commit is linked to task ID 1924711 and PR #30059.

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-ma-fixes-tde branch from 8fa4a6a to b8b191a Apr 15, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Linked pull request(s) odoo/enterprise#3391 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Apr 15, 2019

[IMP] link_tracker, mass_mailing: improve link tracker, click and mai…
…l statistic views

Purpose is to have more information available in list and form views. As
trying to access those models is a technical move let us give users all
necessary information to understand / debug a bit what happens.

Concerning links we add necessary view type and fields to ease understanding
of tracking data. Notably in mass mailing mailing related information is added
for clicks.

This commit is linked to task ID 1924711 and PR #30059.

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.