Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mail, test_mail: new 'History' mailbox in Discuss #30067

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@nla-odoo
Copy link
Contributor

nla-odoo commented Jan 9, 2019

@C3POdoo C3POdoo added the RD label Jan 9, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 9, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 9, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 10, 2019

@robodoo robodoo removed the CI 🤖 label Jan 10, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 10, 2019

@robodoo robodoo added the CI 🤖 label Jan 10, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 10, 2019

@robodoo robodoo removed the CI 🤖 label Jan 10, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch 3 times, most recently Jan 10, 2019

@robodoo robodoo added the CI 🤖 label Jan 10, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 10, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 10, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 11, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 11, 2019

@robodoo robodoo removed the CI 🤖 label Jan 11, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch 2 times, most recently Jan 11, 2019

@robodoo robodoo added the CI 🤖 label Jan 11, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 11, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 22, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 22, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Jan 24, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 24, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Feb 18, 2019

@robodoo robodoo removed the CI 🤖 label Feb 18, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch 5 times, most recently Feb 19, 2019

@robodoo robodoo added the CI 🤖 label Feb 25, 2019

@mba-odoo

This comment has been minimized.

Copy link
Contributor

mba-odoo commented Feb 25, 2019

LGTM

@alexkuhn
Copy link
Contributor

alexkuhn left a comment

Messages are moved away from Inbox on receiving a mark_as_read notification on the long poll.
I think moving messages to History should follow the same logic.

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch Mar 8, 2019

[IMP] mail, test_mail: new 'History' mailbox in Discuss
This commit adds a new mailbox in the Discuss app called 'History'.
Messages that have been marked as read are moved to 'History'.

Note that this feature only works with notification management
handled in Odoo, which can be changed in the user preferences.

Task-ID 40597

@robodoo robodoo removed the CI 🤖 label Mar 8, 2019

@nla-odoo nla-odoo force-pushed the odoo-dev:master-mail-history-nla branch to 7d69d65 Mar 8, 2019

@@ -124,11 +124,11 @@ var Mailbox = SearchableThread.extend({
*/
markAllMessagesAsRead: function (domain) {
if (this._id === 'mailbox_inbox' && this.getMailboxCounter() > 0) {
this.trigger_up('move_messages_to_history', { messages: this.getMessages() });

This comment has been minimized.

@alexkuhn

alexkuhn Mar 18, 2019

Contributor

It should not add messages to history right away, after marking messages as read. Instead, it should wait the longpolling response that messages have been marked as read, similarly to how messages are removed from inbox.

Here is where messages are removed from Inbox from the mark_as_read notification on the longpolling:
https://github.com/odoo-dev/odoo/blob/master-mail-history-nla/addons/mail/static/src/js/services/mail_notification_manager.js#L327

The messages should be added to History here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.