Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[payment_razorpay] Razorpay payment gateway for India #30101

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@sza-odoo
Copy link

sza-odoo commented Jan 10, 2019

Task: https://www.odoo.com/web#id=1904990&action=327&model=project.task&view_type=form&menu_id=4720

Razorpay is a payments solution in India which allows businesses to accept, process and disburse payments.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Jan 10, 2019

@C3POdoo C3POdoo added the RD label Jan 10, 2019

@robodoo robodoo added the CI 🤖 label Jan 10, 2019

@rop-odoo rop-odoo force-pushed the odoo-dev:master-razorpay-payment-integration-sza branch Jan 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 11, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-razorpay-payment-integration-sza branch Jan 15, 2019

@robodoo robodoo removed the CI 🤖 label Jan 15, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-razorpay-payment-integration-sza branch 2 times, most recently to a636f8b Jan 15, 2019

@robodoo robodoo added the CI 🤖 label Jan 15, 2019

@mart-e
Copy link
Contributor

mart-e left a comment

Looks good after a first review, just a few comments


txs = self.env['payment.transaction'].search([('reference', '=', reference)])
if not txs or len(txs) > 1:
error_msg = 'Razorpay: received data for reference %s' % (reference)

This comment has been minimized.

@mart-e

mart-e Feb 8, 2019

Contributor

untranslated error message

@api.multi
def _razorpay_form_get_invalid_parameters(self, data):
invalid_parameters = []
if float_compare(float(data.get('amount', '0.0')) / 100, self.amount, precision_digits=2) != 0:

This comment has been minimized.

@mart-e

mart-e Feb 8, 2019

Contributor

you no longer need to cast to float in pytyon3, 1/2 gives 0.5 now (and for p2, an easier way is to divide by 100.0)

function display_razorpay_form(provider_form) {
// Open Checkout with further options
var payment_form = $('.o_payment_form');
if(!payment_form.find('i').length)

This comment has been minimized.

@mart-e

mart-e Feb 8, 2019

Contributor

Is there some missing brackets here? payment_form.attr('disabled','disabled'); is indented as inside this if

@sza-odoo sza-odoo force-pushed the odoo-dev:master-razorpay-payment-integration-sza branch from a636f8b Feb 8, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 8, 2019

@tivisse tivisse closed this Feb 12, 2019

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Feb 12, 2019

@mart-e

This comment has been minimized.

Copy link
Contributor

mart-e commented Feb 20, 2019

reverting ccavenue and reconsidering razorpay instead 🎉

@mart-e mart-e reopened this Feb 20, 2019

@robodoo robodoo removed the closed 💔 label Feb 20, 2019

@mart-e mart-e force-pushed the odoo-dev:master-razorpay-payment-integration-sza branch Feb 20, 2019

[ADD] payment_razorpay: added new module for payment integration
Razorpay is a payments solution in India which allows businesses to accept, process and disburse payments.

Related Task ID: 1904990

Co-authored-by: Rohan Patel <rop@odoo.com>

@mart-e mart-e force-pushed the odoo-dev:master-razorpay-payment-integration-sza branch to 07712aa Feb 20, 2019

@robodoo robodoo added the CI 🤖 label Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.