Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] studio: studio widgets improvements #30131

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@jso-odoo
Copy link
Contributor

commented Jan 11, 2019

Description of the issue/feature this PR addresses:
Task: https://www.odoo.com/web#id=1918327&action=327&model=project.task&view_type=form&menu_id=4720
Pad: https://pad.odoo.com/p/r.aa716e047f2963e27e3b789ea1921ced

Current behavior before PR:

  • Widget names are not user friendly
  • Unnecessary widgets were there which are not compatible with field type

Desired behavior after PR is merged:

  • Widget names will be user friendly
  • Unnecessary widgets are removed which are not compatible with field type

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Jan 11, 2019

@C3POdoo C3POdoo added the RD label Jan 11, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch Jan 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 11, 2019

@robodoo robodoo removed the CI 🤖 label Jan 18, 2019

@msh-odoo msh-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch 2 times, most recently Jan 18, 2019

@robodoo robodoo added the CI 🤖 label Jan 18, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch Feb 6, 2019

@robodoo robodoo removed the CI 🤖 label Feb 6, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch Feb 6, 2019

@msh-odoo msh-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch to 0bf744f Feb 6, 2019

@robodoo robodoo added the CI 🤖 label Feb 6, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 11, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch to 409a212 Mar 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 11, 2019

@msh-odoo msh-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch from 10584e3 to 5a8c8d4 Mar 12, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 12, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch from 5a8c8d4 to d0a5c43 Apr 1, 2019

@robodoo robodoo removed the CI 🤖 label Apr 1, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch 3 times, most recently from f30dd86 to 7f5a247 Apr 1, 2019

@robodoo robodoo added the CI 🤖 label Apr 1, 2019

@msh-odoo msh-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch from e9a04ff to def586f Apr 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 19, 2019

@mge-odoo mge-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch from def586f to 38a4e10 Apr 23, 2019

@robodoo robodoo removed the CI 🤖 label Apr 23, 2019

@mge-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

robodoo rebase-ff r+

@robodoo robodoo added the r+ 👌 label Apr 23, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Merge method set to rebase and fast-forward

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

'ci/runbot' failed on this reviewed PR.

1 similar comment
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

'ci/runbot' failed on this reviewed PR.

@mge-odoo mge-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch from 38a4e10 to 73e2a2d Apr 24, 2019

@robodoo robodoo removed the r+ 👌 label Apr 24, 2019

[REF] web, *: remove `one2many_list` widget
This widget was exactly the same as a `one2many` and was kept for backward
compatibility reasons. It can be safely removed in master.

Related to task 1918327

@mge-odoo mge-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch from 73e2a2d to 8bea14f Apr 24, 2019

@robodoo robodoo added the CI 🤖 label Apr 24, 2019

@mge-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Apr 24, 2019

[IMP] web, *: add a description to generic widgets
A `description` key has been added on AbstractField and all generic
field widgets ; it is used to display a more user friendly name (both in
the webclient and in Studio).

Non-generic field widgets have an empty string as description.

Related task 1918327

Co-authored-by: Mohammed Shekha <msh@openerp.com>

@mge-odoo mge-odoo force-pushed the odoo-dev:master-studio-widgets-jso branch from 8bea14f to deca6f8 Apr 24, 2019

@mge-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 24, 2019

[IMP] web, *: add a description to generic widgets
A `description` key has been added on AbstractField and all generic
field widgets ; it is used to display a more user friendly name (both in
the webclient and in Studio).

Non-generic field widgets have an empty string as description.

Related task 1918327

closes #30131

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>


Co-authored-by: Mohammed Shekha <msh@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.