New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] models: make prefetching more specific in read() #30133

Closed
wants to merge 1 commit into
base: 10.0
from

Conversation

Projects
None yet
5 participants
@rco-odoo
Copy link
Member

rco-odoo commented Jan 11, 2019

Commit a07a076 restricts the prefetching to self when accessing the fields to return. This is too restrictive, as it cancels prefetching of secondary records in computed fields. In this commit we limit the scope of the restriction to self's model only; this fixes the original issue without impacting other models.

@robodoo robodoo added the seen 🙂 label Jan 11, 2019

@C3POdoo C3POdoo added the RD label Jan 11, 2019

[FIX] models: make prefetching more specific in read()
Commit a07a076 restricts the prefetching to
`self` when accessing the fields to return.  This is too restrictive, as it
cancels prefetching of secondary records in computed fields.  In this commit we
limit the scope of the restriction to `self`'s model only; this fixes the
original issue without impacting other models.
@nim-odoo

This comment has been minimized.

Copy link
Contributor

nim-odoo commented Jan 11, 2019

Before the fix:

Start: 2019-01-11 12:37:08.694128
Stop:  2019-01-11 12:50:45.377022


After the fix:

Start: 2019-01-11 12:51:34.199081
Stop:  2019-01-11 12:52:53.622259

From a performance PoV, this is ok.

@rco-odoo

This comment has been minimized.

Copy link
Member

rco-odoo commented Jan 11, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Jan 11, 2019

robodoo pushed a commit that referenced this pull request Jan 11, 2019

[FIX] models: make prefetching more specific in read()
Commit a07a076 restricts the prefetching to
`self` when accessing the fields to return.  This is too restrictive, as it
cancels prefetching of secondary records in computed fields.  In this commit we
limit the scope of the restriction to `self`'s model only; this fixes the
original issue without impacting other models.

closes #30133
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Jan 11, 2019

Staging failed: ci/runbot on 6ea47ce3d3e73dc0ddd4899142f6da0f5f4344fb (view more at http://runbot.odoo.com/runbot/build/426205)

@nim-odoo

This comment has been minimized.

Copy link
Contributor

nim-odoo commented Jan 11, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Jan 11, 2019

Staging failed: ci/runbot on 6e709d149d97f6ac6f705628a8ebe9906628e3d9 (view more at http://runbot.odoo.com/runbot/build/426237)

@robodoo robodoo added the error 🙅 label Jan 11, 2019

@rco-odoo

This comment has been minimized.

Copy link
Member

rco-odoo commented Jan 11, 2019

robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Jan 11, 2019

@KangOl

This comment has been minimized.

Copy link
Contributor

KangOl commented Jan 11, 2019

@robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Jan 11, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/426292)

@robodoo robodoo added the error 🙅 label Jan 11, 2019

@KangOl

This comment has been minimized.

Copy link
Contributor

KangOl commented Jan 11, 2019

@robodoo R E T R Y. retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Jan 11, 2019

Staging failed: ci/runbot on ef4c4a0521163c8826b7465c2e91811d8c154258 (view more at http://runbot.odoo.com/runbot/build/426310)

@robodoo robodoo added the error 🙅 label Jan 11, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor

nim-odoo commented Jan 14, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Jan 14, 2019

Merged, thanks!

@robodoo robodoo closed this Jan 14, 2019

@nim-odoo nim-odoo deleted the odoo-dev:10.0-read-prefetch-rco branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment