New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mail: chat window positioning with discuss open #30137

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
3 participants
@alexkuhn
Copy link
Contributor

alexkuhn commented Jan 11, 2019

Before this commit, the process of positioning chat windows
could fail if one of the tabs had discuss open.

When a chat window was hidden and become visible, the algorithm
was not updating the state of the chat window to "visible" when
discuss was open. As a result, it was always trying to make it
visible, resulting in an infinite loop and raising the following
error message:

Uncaught RangeError: Maximum call stack size exceeded

This commit ensures it works even when discuss is open.

opw-1919327

[FIX] mail: chat window positioning with discuss open
Before this commit, the process of positioning chat windows
could fail if one of the tabs had discuss open.

When a chat window was hidden and become visible, the algorithm
was not updating the state of the chat window to "visible" when
discuss was open. As a result, it was always trying to make it
visible, resulting in an infinite loop and raising the following
error message:

`Uncaught RangeError: Maximum call stack size exceeded`

This commit ensures it works even when discuss is open.

opw-1919327

@alexkuhn alexkuhn self-assigned this Jan 11, 2019

@robodoo robodoo added the seen 🙂 label Jan 11, 2019

@alexkuhn alexkuhn requested a review from Xavier-Do Jan 11, 2019

@Xavier-Do

This comment has been minimized.

Copy link
Contributor

Xavier-Do commented Jan 11, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 11, 2019

[FIX] mail: chat window positioning with discuss open
Before this commit, the process of positioning chat windows
could fail if one of the tabs had discuss open.

When a chat window was hidden and become visible, the algorithm
was not updating the state of the chat window to "visible" when
discuss was open. As a result, it was always trying to make it
visible, resulting in an infinite loop and raising the following
error message:

`Uncaught RangeError: Maximum call stack size exceeded`

This commit ensures it works even when discuss is open.

opw-1919327

closes #30137
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Jan 11, 2019

Merged, thanks!

@robodoo robodoo closed this Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment