Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] base: ir.model.fields.selection #30228

Closed

Conversation

@mart-e
Copy link
Contributor

mart-e commented Jan 15, 2019

@robodoo robodoo added the seen 🙂 label Jan 15, 2019
@C3POdoo C3POdoo added the RD label Jan 15, 2019
@robodoo robodoo added the CI 🤖 label Jan 15, 2019
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
@mart-e mart-e force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch Jan 16, 2019
@robodoo robodoo removed the CI 🤖 label Jan 16, 2019
Copy link
Member

rco-odoo left a comment

A few more 😉

odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
odoo/addons/base/models/ir_model.py Outdated Show resolved Hide resolved
@mart-e mart-e force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch Jan 17, 2019
@nhomar

This comment has been minimized.

Copy link
Collaborator

nhomar commented Jan 17, 2019

Will this make base selection fields editable on the selection options from odoo-studio?

@mart-e

This comment has been minimized.

Copy link
Contributor Author

mart-e commented Jan 17, 2019

@nhomar not yet but that is one of the goals in the end 👍

@mart-e mart-e force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch 4 times, most recently Jan 17, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 18, 2019
@rco-odoo rco-odoo force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch Jan 21, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 22, 2019
@mart-e mart-e force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch 3 times, most recently Jan 23, 2019
@robodoo robodoo added the CI 🤖 label Jan 25, 2019
@mart-e mart-e force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch 2 times, most recently from b81388e to 7d05bd6 Aug 13, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Aug 13, 2019
@mart-e mart-e force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch 2 times, most recently from bbbcfd8 to 2f05cba Aug 13, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Aug 13, 2019
@rco-odoo rco-odoo force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch 4 times, most recently from 6223688 to 2196897 Aug 14, 2019
@rco-odoo rco-odoo force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch from 2196897 to db2dce2 Aug 14, 2019
@mart-e mart-e force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch from db2dce2 to cfad0b1 Aug 19, 2019
@robodoo robodoo added the CI 🤖 label Aug 19, 2019
The selection values of a selection field are now stored in database in the
model ir.model.fields.selection

This will allow to have a modular approche on selections and each selection
is now linked to the module that declared it.
Previously to this change, the selections were linked to the field, meaning
uninstalling a module had no impact on the selections stored on database.

With this change, the selections will now be translated in the correct module
(having an external id) and the records having a used selection will now be
reset to null.

Co-authored-by: Raphaël Collet <rco@odoo.com>
@mart-e mart-e force-pushed the odoo-dev:master-ir-model-fields-selection-mat branch from cfad0b1 to 01540f2 Aug 19, 2019
@mart-e

This comment has been minimized.

Copy link
Contributor Author

mart-e commented Aug 19, 2019

@robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 and removed CI 🤖 labels Aug 19, 2019
robodoo pushed a commit that referenced this pull request Aug 19, 2019
The selection values of a selection field are now stored in database in the
model ir.model.fields.selection

This will allow to have a modular approche on selections and each selection
is now linked to the module that declared it.
Previously to this change, the selections were linked to the field, meaning
uninstalling a module had no impact on the selections stored on database.

With this change, the selections will now be translated in the correct module
(having an external id) and the records having a used selection will now be
reset to null.

closes #30228

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>


Co-authored-by: Raphaël Collet <rco@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Aug 19, 2019

Merged at 7593b88, thanks!

@robodoo robodoo closed this Aug 19, 2019
@mart-e mart-e deleted the odoo-dev:master-ir-model-fields-selection-mat branch Aug 19, 2019
dbeguin added a commit to odoo-dev/odoo that referenced this pull request Aug 21, 2019
The selection values of a selection field are now stored in database in the
model ir.model.fields.selection

This will allow to have a modular approche on selections and each selection
is now linked to the module that declared it.
Previously to this change, the selections were linked to the field, meaning
uninstalling a module had no impact on the selections stored on database.

With this change, the selections will now be translated in the correct module
(having an external id) and the records having a used selection will now be
reset to null.

closes odoo#30228

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>


Co-authored-by: Raphaël Collet <rco@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.