Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] dashboard view: display imp #30288

Closed
wants to merge 2 commits into
base: 12.0
from

Conversation

Projects
None yet
4 participants
@hbh-odoo
Copy link
Contributor

hbh-odoo commented Jan 17, 2019

Description of the issue/feature this PR addresses:

Task: https://www.odoo.com/web?#id=1917958&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
Pad: https://pad.odoo.com/p/r.c823631022033d11e887856d7ca025a3

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Jan 17, 2019

@C3POdoo C3POdoo added the RD label Jan 17, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 17, 2019

@Polymorphe57 Polymorphe57 force-pushed the odoo-dev:12.0-dashboard-view-imp-hbh branch Feb 21, 2019

@robodoo robodoo removed the CI 🤖 label Feb 21, 2019

@Polymorphe57 Polymorphe57 force-pushed the odoo-dev:12.0-dashboard-view-imp-hbh branch 3 times, most recently Feb 21, 2019

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

@aab-odoo
Copy link
Contributor

aab-odoo left a comment

Commit message: 'an appropriate in' weird

var $svgContainer = $('<div/>', {class: 'o_graph_svg_container'});


var $svgContainer = $('<div/>', { class: 'o_graph_svg_container'});

This comment has been minimized.

@aab-odoo

aab-odoo Feb 21, 2019

Contributor

too much blank lines

addons/web/static/src/js/views/graph/graph_renderer.js Outdated
var $svgContainer = $('<div/>', { class: 'o_graph_svg_container'});
// Split the tooltip into columns for large data because some portion goes out off the screen.
if (data.length >= SPLIT_THRESHOLD) {
$svgContainer.addClass('tooltip_split_in_columns');

This comment has been minimized.

@aab-odoo

aab-odoo Feb 21, 2019

Contributor

prefix all odoo classnames by o_

hbh-odoo added some commits Dec 17, 2018

[IMP] web: properly display min and max abs when less that 3 abs.
In graph line mode, min and max abs are
displayed beyond the screen when there are less
than 3 abs.
This is happening because nvd3 fixes their
text-anchor to 'middle'. The present commit fixes
correctly their text-anchors to start and end
respectively by using the '!important' rule (it
seems difficult to do otherwise).

Co-authored-by: Mohammed Shekha <msh@openerp.com>

Related to Task: 1917958
[FIX] web: several columns in line chart tooltips for large data
Currently tooltip goes out off the screen when the
graph view (in line mode) presents a large number
of groups.
The present commit splits the tooltip content in
three columns when the number of groups exceeds
20. This split is not done in mobile mode because
it is not an appropriate in that situation.

Co-authored-by: Mohammed Shekha <msh@openerp.com>

Related to Task: 1917958

@Polymorphe57 Polymorphe57 force-pushed the odoo-dev:12.0-dashboard-view-imp-hbh branch to 98dd254 Feb 21, 2019

@robodoo robodoo removed the CI 🤖 label Feb 21, 2019

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Feb 21, 2019

robodoo r+

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Feb 21, 2019

robodoo rebase-ff

@robodoo robodoo added the r+ 👌 label Feb 21, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 21, 2019

Merge method set to rebase and fast-forward

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

@robodoo robodoo closed this in bb6aec1 Feb 21, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Feb 21, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 21, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.