Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] product: Pricelist with multiple based other items only process the first item #30453

Open
wants to merge 1 commit into
base: 11.0
from

Conversation

@carlosdauden
Copy link
Contributor

carlosdauden commented Jan 22, 2019

Description of the issue/feature this PR addresses:
Pricelist with multiple based other items only process

Current behavior before PR:
Only process first global based on other pricelist

Desired behavior after PR is merged:
If do not match item in the based pricelist continue with other global items

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@Tecnativa

@carlosdauden carlosdauden force-pushed the Tecnativa:11.0-fix-product-multi_base_pricelist branch to 56c5d20 Jun 18, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jun 18, 2019
@dbo-odoo dbo-odoo added the Sales label Oct 2, 2019
@dbo-odoo

This comment has been minimized.

Copy link
Contributor

dbo-odoo commented Oct 2, 2019

While I understand the use case, this is definitely not something we can do in stable.

We might target it for master, but since this is a rather important change in behaviour, I will need to discuss it with my Product Owner (@fgi-odoo). It's cealry an [IMP] and not a [FIX]... I'll need to discuss the change (and also discuss how a migration might need to introduce new rules to keep the same behaviour for people that switch versions).

Could you describe the use-case very precisely (e.g. with examples/video/screenshot)? Even now that you've showed it to me, it's rather difficult to explain properly without being confusing 😃

@carlosdauden carlosdauden force-pushed the Tecnativa:11.0-fix-product-multi_base_pricelist branch from 56c5d20 to 7803a4b Dec 2, 2019
@robodoo robodoo removed the CI 🤖 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.