Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mass_mailing: fix send email issue. #30533

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants

@robodoo robodoo added the seen 🙂 label Jan 25, 2019

@sga-odoo

This comment has been minimized.

Copy link
Member Author

sga-odoo commented Jan 25, 2019

@Gorash I have fixed one issue related to wysiwyg. Can you look at this?

@robodoo robodoo added the CI 🤖 label Jan 25, 2019

@C3POdoo C3POdoo added the RD label Jan 25, 2019

@Gorash
Copy link
Contributor

Gorash left a comment

Thank you for the suggestion, on the other hand it's strange to be able to commit changes while the editor is not loaded. It is absolutely necessary to add a test (in mass_mailing_html_tests.js). Thanks

@mgh-odoo mgh-odoo force-pushed the odoo-dev:master-mass-mailing-send-mail-fix-sga branch Jan 30, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 30, 2019

@mgh-odoo mgh-odoo force-pushed the odoo-dev:master-mass-mailing-send-mail-fix-sga branch Jan 30, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 30, 2019

Show resolved Hide resolved addons/mass_mailing/static/src/js/mass_mailing_widget.js Outdated

@sga-odoo sga-odoo force-pushed the odoo-dev:master-mass-mailing-send-mail-fix-sga branch Jan 31, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 31, 2019

@Gorash

This comment has been minimized.

Copy link
Contributor

Gorash commented Feb 4, 2019

@hmo-odoo 👍
@ged-odoo I do not have access robodo, can you look or give me rights. thanks.

Show resolved Hide resolved addons/mass_mailing/static/tests/mass_mailing_html_tests.js Outdated
Show resolved Hide resolved addons/mass_mailing/static/tests/mass_mailing_html_tests.js Outdated

@mgh-odoo mgh-odoo force-pushed the odoo-dev:master-mass-mailing-send-mail-fix-sga branch Feb 5, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 5, 2019

@Gorash

Gorash approved these changes Feb 12, 2019

@Gorash

This comment has been minimized.

Copy link
Contributor

Gorash commented Feb 18, 2019

Show resolved Hide resolved addons/mass_mailing/static/tests/mass_mailing_html_tests.js Outdated
Show resolved Hide resolved addons/mass_mailing/static/tests/mass_mailing_html_tests.js Outdated
Show resolved Hide resolved addons/mass_mailing/static/tests/mass_mailing_html_tests.js Outdated
Show resolved Hide resolved addons/web_editor/static/src/js/backend/convert_inline.js Outdated
@VincentSchippefilt

This comment has been minimized.

Copy link
Contributor

VincentSchippefilt commented Feb 18, 2019

robodoo delegate=Gorash

@sga-odoo sga-odoo force-pushed the odoo-dev:master-mass-mailing-send-mail-fix-sga branch Feb 19, 2019

@robodoo robodoo removed the CI 🤖 label Feb 19, 2019

@sga-odoo

This comment has been minimized.

Copy link
Member Author

sga-odoo commented Feb 19, 2019

@VincentSchippefilt Suggested changes has been done. Thanks

@sga-odoo sga-odoo force-pushed the odoo-dev:master-mass-mailing-send-mail-fix-sga branch Feb 19, 2019

@robodoo robodoo added the CI 🤖 label Feb 19, 2019

@@ -42,6 +42,9 @@ var MassMailingFieldHtml = FieldHtml.extend({
var self = this;
var fieldName = this.nodeOptions['inline-field'];

if (this.mode == "readonly") {

This comment has been minimized.

@Gorash

Gorash Feb 19, 2019

Contributor

the condition does not cover all cases. If you click on 'edit' then directly on 'save':

Uncaught TypeError: Cannot read property 'find' of undefined
http://451917-30533-f519b2.runbot15.odoo.com/mass_mailing/static/src/js/mass_mailing_widget.js:48

This comment has been minimized.

@sga-odoo

sga-odoo Feb 20, 2019

Author Member

Hello @Gorash ,
This PR is related to this bug https://www.odoo.com/web#id=1932061&action=333&active_id=1278&model=project.task&view_type=form&menu_id=4720

The case you are talking about will be taken care in another task with ref link https://www.odoo.com/web#id=1932687&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720

Reference PR #30833

SO if you want to merge both into one let me know so we will merge both issue with the one pr and will cancel another one.

Thanks

This comment has been minimized.

@Gorash

Gorash Feb 25, 2019

Contributor

👍

[FIX] mass_mailing: fix send email issue.
 - while clicking on send now button in mass mailing app it throws error due to wysiwyg undefined.

@Gorash Gorash force-pushed the odoo-dev:master-mass-mailing-send-mail-fix-sga branch to 0a8bb9e Feb 25, 2019

@robodoo robodoo removed the CI 🤖 label Feb 25, 2019

@Gorash

This comment has been minimized.

Copy link
Contributor

Gorash commented Feb 25, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 25, 2019

[FIX] mass_mailing: fix send email issue.
 - while clicking on send now button in mass mailing app it throws error due to wysiwyg undefined.

closes #30533
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 25, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.