Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imp] point_of_sale: Improve pos payment journal filter #30748

Closed

Conversation

Projects
None yet
5 participants
@jva-odoo
Copy link
Contributor

commented Feb 1, 2019

Before this commit, payment journal "Available in PoS" should not
ticked by default if created from PoS. And if I remove the filter
"Available in PoS", I should not see all payments methods.

Now, payment journal "Available in PoS" is ticked by default if
created from PoS. And if I remove the filter "Available in PoS",
I should see all payment methods.

Task: https://www.odoo.com/web#id=1932119&action=327&model=project.task&view_type=form&menu_id=4720
Pad: https://pad.odoo.com/p/r.c252e5a10404856f15dc205a2ddf0497

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 1, 2019

@C3POdoo C3POdoo added the RD label Feb 1, 2019

@robodoo robodoo added the CI 🤖 label Feb 1, 2019

@jva-odoo jva-odoo force-pushed the odoo-dev:master-pos-payments-methods-jva branch Mar 5, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 5, 2019

@jva-odoo jva-odoo force-pushed the odoo-dev:master-pos-payments-methods-jva branch to 9064dc9 Mar 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 11, 2019

@switch87
Copy link
Contributor

left a comment

@qle-odoo robodoo

@qle-odoo

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@jva-odoo add commit message for 9064dc9 and description for pull request

@switch87 try qle r+

@switch87

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@jva-odoo add commit message for 9064dc9 and description for pull request

@jva-odoo I cherry-picked this commit to 11.0, you can eventually remove it from this pr or use the same title/commit-message.

@qle-odoo Sorry, tagged you to early ;)

@switch87

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@jva-odoo can you change the commit messages so we can merge? Thank you.

[imp] point_of_sale: payment journal filter
Before this commit, payment journal "Available in PoS" should not
ticked by default if created from PoS. And if I remove the filter
"Available in PoS", I should not see all payments methods.

Now, payment journal "Available in PoS" is ticked by default if
created from PoS. And if I remove the filter "Available in PoS",
I should see all payment methods.

@switch87 switch87 force-pushed the odoo-dev:master-pos-payments-methods-jva branch from 9064dc9 to e3b9ee7 Apr 18, 2019

@robodoo robodoo removed the CI 🤖 label Apr 18, 2019

@switch87

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@qle-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@robodoo robodoo added the r+ 👌 label Apr 18, 2019

robodoo pushed a commit that referenced this pull request Apr 18, 2019

[imp] point_of_sale: payment journal filter
Before this commit, payment journal "Available in PoS" should not
ticked by default if created from PoS. And if I remove the filter
"Available in PoS", I should not see all payments methods.

Now, payment journal "Available in PoS" is ticked by default if
created from PoS. And if I remove the filter "Available in PoS",
I should see all payment methods.

closes #30748

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 18, 2019

@switch87 switch87 deleted the odoo-dev:master-pos-payments-methods-jva branch Apr 18, 2019

Arcasias added a commit to odoo-dev/odoo that referenced this pull request Apr 19, 2019

[imp] point_of_sale: payment journal filter
Before this commit, payment journal "Available in PoS" should not
ticked by default if created from PoS. And if I remove the filter
"Available in PoS", I should not see all payments methods.

Now, payment journal "Available in PoS" is ticked by default if
created from PoS. And if I remove the filter "Available in PoS",
I should see all payment methods.

closes odoo#30748

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.