Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][l10n_ma]: Add new module for Moroccan Localization #30772

Open
wants to merge 2 commits into
base: 12.0
from

Conversation

Projects
None yet
5 participants
@KARIZMA-CONSEIL
Copy link

KARIZMA-CONSEIL commented Feb 1, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:
This is global review for the moroccan localization module since the old module has not been maintained for a long time. The new module:

  • Add the account group
  • Fix the default proposed taxes
  • Fix the default account setting
  • Add the ICE identifier for footer reports and invoice reports.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 1, 2019

rgo-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 4, 2019

@rgo-odoo

This comment has been minimized.

Copy link
Contributor

rgo-odoo commented Mar 4, 2019

@KARIZMA-CONSEIL @saadthaifa I see you added few account.group records, but you never use them, can you please assign them to appropriate accounts. thanks.

<field name="name">Autres produits finis</field>
<field name="code">3158</field>
<field name="user_type_id" ref="account.data_account_type_revenue"/>
<field name="chart_template_id"

This comment has been minimized.

Copy link
@jco-odoo

jco-odoo Mar 6, 2019

Contributor

acomptes verss? (something missing?)
Could you tell us why you put this liability account as reconcilable?

@KARIZMA-CONSEIL

This comment has been minimized.

Copy link
Author

KARIZMA-CONSEIL commented Mar 29, 2019

Hello @rgo-odoo,
Can you merge the new changes made ?

@jco-odoo

This comment has been minimized.

Copy link
Contributor

jco-odoo commented Mar 29, 2019

@KARIZMA-CONSEIL This is quite a heavy change in stable. If you keep the same tags, ... this might however be possible. I don't see why you added plenty .po files, just the .pot should suffice.

@rgo-odoo We can still convert the xml to csv for the account templates as there are quite a lot of them. (perf) Can you have a first look also if it is really possible in stable.

@jco-odoo

This comment has been minimized.

Copy link
Contributor

jco-odoo commented Mar 29, 2019

@KARIZMA-CONSEIL Why is the tax group removed?

rgo-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 1, 2019

rgo-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 1, 2019

[IMP] l10n_ma: added Common Company Identifier - ICE field on res.par…
…tner model

made it related on res.company model
displayed it on report header and invoice report

was task: 1913323
diff taken from odoo#30772

rgo-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 1, 2019

[FIX] l10n_ma: Fixed CoA
- fixed account types for few accounts
- set reconcile field for few accounts
- added new 'Achats des prestations de service'(code: 61263) account
- reflected accounts in chart template configuration

was task: 1913323
diff taken from PR odoo#30772
@rgo-odoo

This comment has been minimized.

Copy link
Contributor

rgo-odoo commented Apr 1, 2019

@KARIZMA-CONSEIL I have reworked on your code and took important changes and split your PR into two, #32296 will go into V12 and #32297 will go into master(since it contains database schema changes), can you please have a look at it. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.