Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] point_of_sale: point of sale onboarding improvement. #30808

Closed

Conversation

Projects
None yet
6 participants
@sht-odoo
Copy link
Contributor

sht-odoo commented Feb 4, 2019

task: https://www.odoo.com/web?#id=1925458&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
pad: https://pad.odoo.com/p/r.92c4ea2004c5c7eb0f4c2473346f319c

  • Improved description of point of sale application
  • Removed status from card like 'In Progress' and 'Unused'
  • Click on top-right corner of POS kanban card, it shows 'Sessions' and 'Sales Orders', now it will shows 'Orders' and 'Sessions'. (for usability purpose).
  • Improved Multi-Currencies wording same as invoicing
  • Removed 'Advanced Currencies Setup' from settings(when clicking on 'Multi-Currencies').
  • Improved list view label on 'Point of Sale'.
  • Added 'PoS Product Categories' feature in 'Restrict Available Product Categories'.
  • In PoS config setting, 'Pos Interface' string is put instead of 'Order Interface'.
  • Filter and display issues were there when setting 'Currencies' from 'Multi-Currencies', now it is resolved.
  • String 'PoS Product categories' is put instead of 'PoS Category', as it seems meaningful.
  • 'Restrict Available Product Category' is ticked but any category is not selected (it means it is kept blank), then all categories are shown at POS screen.
  • Allow to set default category from the available categories.
  • 'iface_start_categ_domain_ids' field is removed because domain for 'iface_start_categ_id' is given directly in the model. So 'iface_start_categ_domain_ids' will not be required anymore.

@robodoo robodoo added the CI 🤖 label Feb 4, 2019

@C3POdoo C3POdoo added the RD label Feb 4, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch Feb 13, 2019

@robodoo robodoo removed the CI 🤖 label Feb 13, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch Feb 13, 2019

@robodoo robodoo added the CI 🤖 label Feb 13, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch Feb 14, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 14, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch Mar 7, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 7, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch Mar 7, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 7, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch to 1e48a58 Mar 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 11, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch from 1e48a58 to 55c8ae3 Mar 12, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 12, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 19, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch from a451d4d to 479d8c5 Mar 26, 2019

@robodoo robodoo removed the CI 🤖 label Mar 26, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch from 479d8c5 to 0653f72 Mar 26, 2019

@robodoo robodoo added the CI 🤖 label Mar 26, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch from 0653f72 to d4e4f5b Mar 26, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 26, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch from d4e4f5b to 973d1c8 Mar 26, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 26, 2019

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch from 973d1c8 to 6ef8f8c Mar 29, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 29, 2019

@switch87
Copy link
Contributor

switch87 left a comment

I added some small change requests. Other then these the pr looks good 👍
Don't forget to adjust the commit message.

@@ -110,7 +110,7 @@ def _compute_iface_start_categ_domain_ids(self):
iface_tax_included = fields.Selection([('subtotal', 'Tax-Excluded Price'), ('total', 'Tax-Included Price')], string="Tax Display", default='subtotal', required=True)
iface_start_categ_id = fields.Many2one('pos.category', string='Initial Category',
help='The point of sale will display this product category by default. If no category is specified, all available products will be shown.')
iface_available_categ_ids = fields.Many2many('pos.category', string='Available Category Tree',
iface_available_categ_ids = fields.Many2many('pos.category', string='Available PoS Product Category',

This comment has been minimized.

Copy link
@switch87

switch87 Apr 4, 2019

Contributor

Available PoS Product Categories

@@ -532,6 +532,7 @@ exports.PosModel = Backbone.Model.extend({
var order = typeof model.order === 'function' ? model.order(self,tmp): model.order;
progress += progress_step;


This comment has been minimized.

Copy link
@switch87

switch87 Apr 4, 2019

Contributor

remove this newline from commit

@@ -129,6 +117,21 @@
</div>
</div>
</div>
<div class="col-12 col-lg-6 o_setting_box" attrs="{'invisible': [('limit_categories', '=', False)]}">

This comment has been minimized.

Copy link
@switch87

switch87 Apr 4, 2019

Contributor

remove the invisible attribute. start category is also active if no category limit is set. making this invisible can result in start category set and no possibility to remove it. Also the user should be able to set the start category if they don't want to limit the categories available in the PoS.

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch from 6ef8f8c Apr 4, 2019

@robodoo robodoo removed the CI 🤖 label Apr 4, 2019

@sht-odoo

This comment has been minimized.

Copy link
Contributor Author

sht-odoo commented Apr 4, 2019

@switch87
I have done those changes.

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch Apr 4, 2019

@robodoo robodoo added the CI 🤖 label Apr 4, 2019

@@ -129,6 +117,21 @@
</div>
</div>
</div>
<div class="col-12 col-lg-6 o_setting_box">
<field name="iface_start_categ_domain_ids" invisible="1"/>

This comment has been minimized.

Copy link
@switch87

switch87 Apr 4, 2019

Contributor

Sorry,I looked over this one. You don't need to put this field here any more since you did the calculation in the model.

This comment has been minimized.

Copy link
@sht-odoo

sht-odoo Apr 4, 2019

Author Contributor

done !! :)

[IMP] point_of_sale: point of sale onboarding improvement.
- Improved description of point of sale application
- Removed status from card like 'In Progress' and 'Unused'
- Click on top-right corner of POS kanban card, it shows 'Sessions' and 'Sales Orders', now it will shows 'Orders' and 'Sessions'. (for usability purpose).
- Improved Multi-Currencies wording same as invoicing
- Removed 'Advanced Currencies Setup' from settings(when clicking on 'Multi-Currencies').
- Improved list view label on 'Point of Sale'.
- Added 'PoS Product Categories' feature in 'Restrict Available Product Categories'.
- In PoS config setting, 'Pos Interface' string is put instead of 'Order Interface'.
- Filter and display issues were there when setting 'Currencies' from 'Multi-Currencies', now it is resolved.
- String 'PoS Product categories' is put instead of 'PoS Category', as it seems meaningful.
- 'Restrict Available Product Category' is ticked but any category is not selected (it means it is kept blank), then all categories are shown at POS screen.
- Allow to set default category from the available categories
- 'iface_start_categ_domain_ids' is removed because domain for 'iface_start_categ_id' is given directly in the model. So 'iface_start_categ_domain_ids' will not be required anymore.

 This commit is related to task id: 1925458

@sht-odoo sht-odoo force-pushed the odoo-dev:master-pos-onboarding-improvement-sht branch to 96d7365 Apr 4, 2019

@robodoo robodoo removed the CI 🤖 label Apr 4, 2019

@switch87

This comment has been minimized.

Copy link
Contributor

switch87 commented Apr 4, 2019

@robodoo robodoo added the CI 🤖 label Apr 4, 2019

@qle-odoo

This comment has been minimized.

Copy link
Contributor

qle-odoo commented Apr 5, 2019

@robodoo robodoo added the r+ 👌 label Apr 5, 2019

robodoo pushed a commit that referenced this pull request Apr 5, 2019

[IMP] point_of_sale: point of sale onboarding improvement.
- Improved description of point of sale application
- Removed status from card like 'In Progress' and 'Unused'
- Click on top-right corner of POS kanban card, it shows 'Sessions' and 'Sales Orders', now it will shows 'Orders' and 'Sessions'. (for usability purpose).
- Improved Multi-Currencies wording same as invoicing
- Removed 'Advanced Currencies Setup' from settings(when clicking on 'Multi-Currencies').
- Improved list view label on 'Point of Sale'.
- Added 'PoS Product Categories' feature in 'Restrict Available Product Categories'.
- In PoS config setting, 'Pos Interface' string is put instead of 'Order Interface'.
- Filter and display issues were there when setting 'Currencies' from 'Multi-Currencies', now it is resolved.
- String 'PoS Product categories' is put instead of 'PoS Category', as it seems meaningful.
- 'Restrict Available Product Category' is ticked but any category is not selected (it means it is kept blank), then all categories are shown at POS screen.
- Allow to set default category from the available categories
- 'iface_start_categ_domain_ids' is removed because domain for 'iface_start_categ_id' is given directly in the model. So 'iface_start_categ_domain_ids' will not be required anymore.

 This commit is related to task id: 1925458

closes #30808

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 5, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 5, 2019

@switch87 switch87 deleted the odoo-dev:master-pos-onboarding-improvement-sht branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.