Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] im_livechat: set default user image instead of placeholder #30821

Closed

Conversation

Projects
None yet
4 participants
@jso-odoo
Copy link
Contributor

jso-odoo commented Feb 5, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

  • When user image isn't set, at the time of livechat
    default placeholder is displayed.

Desired behavior after PR is merged:

  • When user image isn't set, at the time of livechat
    default user image will be available instead of the
    default placeholder.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 5, 2019

@C3POdoo C3POdoo added the RD label Feb 5, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch 2 times, most recently Feb 6, 2019

@robodoo robodoo added the CI 🤖 label Feb 7, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Feb 7, 2019

@robodoo robodoo removed the CI 🤖 label Feb 7, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Feb 7, 2019

@robodoo robodoo added the CI 🤖 label Feb 7, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Feb 8, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 8, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Feb 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 11, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Feb 15, 2019

@robodoo robodoo added the CI 🤖 label Feb 15, 2019

@jso-odoo jso-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Feb 15, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 15, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Feb 15, 2019

@robodoo robodoo removed the CI 🤖 label Feb 15, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Feb 15, 2019

@robodoo robodoo added the CI 🤖 label Feb 15, 2019

Show resolved Hide resolved addons/web/controllers/main.py Outdated

@jso-odoo jso-odoo force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch Mar 5, 2019

@robodoo robodoo removed the CI 🤖 label Mar 5, 2019

@robodoo robodoo added the CI 🤖 label Mar 5, 2019

@alexkuhn alexkuhn force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch to 0ceccd0 Mar 5, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 5, 2019

[IMP] im_livechat, web: custom placeholder image
When the user has not set any image, it now displays the default
user image placeholder instead of the image placeholder in livechat.

Task-ID 1924666

@alexkuhn alexkuhn force-pushed the odoo-dev:master-livechat-placeholder-image-jso branch from 0ceccd0 to 67e5420 Mar 18, 2019

@robodoo robodoo removed the CI 🤖 label Mar 18, 2019

@alexkuhn
Copy link
Contributor

alexkuhn left a comment

robodoo pushed a commit that referenced this pull request Mar 18, 2019

[IMP] im_livechat, web: custom placeholder image
When the user has not set any image, it now displays the default
user image placeholder instead of the image placeholder in livechat.

Task-ID 1924666

closes #30821

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 18, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.