Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] product: hide the sales price and taxes. #30903

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@rja-odoo
Copy link
Contributor

commented Feb 7, 2019

Task: https://www.odoo.com/web#id=1936865&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720

Pad : https://pad.odoo.com/p/r.fc5c0297881d02ad8c331d1e7e24356b

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Feb 7, 2019

@rja-odoo rja-odoo force-pushed the odoo-dev:master-hide-product-rja branch to 73c8c67 Feb 22, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 22, 2019

@awa-odoo
Copy link
Contributor

left a comment

Some kanban view stuff to change.

@@ -90,7 +92,7 @@
</strong>
</div>
<div name="tags"/>
<ul>
<ul attrs="{'invisible': [('sale_ok', '=', False)]}">

This comment has been minimized.

Copy link
@awa-odoo

awa-odoo Apr 5, 2019

Contributor

I think this should be t-if="record.sale_ok.raw_value"

@@ -442,7 +444,7 @@
<div class="o_kanban_tags_section">
<field name="attribute_value_ids" groups="product.group_product_variant"/>
</div>
<ul>
<ul attrs="{'invisible': [('sale_ok', '=', False)]}">

This comment has been minimized.

Copy link
@awa-odoo

awa-odoo Apr 5, 2019

Contributor

Same here.

@rja-odoo rja-odoo force-pushed the odoo-dev:master-hide-product-rja branch from 73c8c67 to fe661b6 Apr 5, 2019

@robodoo robodoo removed the CI 🤖 label Apr 5, 2019

@rja-odoo rja-odoo force-pushed the odoo-dev:master-hide-product-rja branch from fe661b6 to 4ca6d70 Apr 5, 2019

@robodoo robodoo added the CI 🤖 label Apr 5, 2019

[IMP] product: hide sale/taxes related fields if product not sellable
This commit will hide the sale and taxes related fields in the form view if the product
is not 'sale_ok'.

Task #1936865
Closes #30903

@mba-odoo mba-odoo force-pushed the odoo-dev:master-hide-product-rja branch from 4ca6d70 to 82cde41 Apr 24, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.