New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] stock: location company #30952

Closed
wants to merge 1 commit into
base: 10.0
from

Conversation

Projects
None yet
2 participants
@nim-odoo
Copy link
Contributor

nim-odoo commented Feb 8, 2019

Force the location and destination location's company to match with the
picking and picking type company. This is to prevent users to move
products between companies without using a transit location.

opw-1893276

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@nim-odoo nim-odoo self-assigned this Feb 8, 2019

@robodoo robodoo added the seen 🙂 label Feb 8, 2019

@robodoo robodoo added the CI 🤖 label Feb 8, 2019

@nim-odoo nim-odoo removed the Blocked label Feb 11, 2019

[FIX] stock: location company
Force the location and destination location's company to match with the
picking and picking type company. This is to prevent users to move
products between companies without using a transit location, since stock
valuation is not supported.

The record rule `stock_location_comp_rule` gives access to children
companies. The domain added in the view is more restrictive, and allows,
for a company A, transfers from locations:
Company A -> Company A
Company A -> No Company
No Company -> Company A

opw-1893276

@nim-odoo nim-odoo force-pushed the odoo-dev:10.0-opw-1893276-domain_location-nim branch from 7ebcc53 to 212e73b Feb 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 11, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

nim-odoo commented Feb 11, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 11, 2019

[FIX] stock: location company
Force the location and destination location's company to match with the
picking and picking type company. This is to prevent users to move
products between companies without using a transit location, since stock
valuation is not supported.

The record rule `stock_location_comp_rule` gives access to children
companies. The domain added in the view is more restrictive, and allows,
for a company A, transfers from locations:
Company A -> Company A
Company A -> No Company
No Company -> Company A

opw-1893276

closes #30952
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 11, 2019

Staging failed: ci/runbot on 8d8db4bba0047423dc49d5c5474245d080c322db (view more at http://runbot.odoo.com/runbot/build/445816)

@robodoo robodoo added the error 🙅 label Feb 11, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

nim-odoo commented Feb 12, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 12, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 12, 2019

@nim-odoo nim-odoo deleted the odoo-dev:10.0-opw-1893276-domain_location-nim branch Feb 12, 2019

KangOl added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[FIX] stock: remove domain on stock.location of picking types
There is no `company_id` field on `stock.picking.type`.

Partially revert f221936 (odoo#30952)

robodoo pushed a commit that referenced this pull request Feb 14, 2019

[FIX] stock: remove domain on stock.location of picking types
There is no `company_id` field on `stock.picking.type`.

Partially revert f221936 (#30952)

closes #31121

robodoo pushed a commit that referenced this pull request Feb 18, 2019

[FIX] stock: remove domain on stock.location of picking types
There is no `company_id` field on `stock.picking.type`.

Partially revert f221936 (#30952)

closes #31121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment