Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[FIX] hr_expense: multi-currency #30959
+88
−15
Conversation
robodoo
added
the
seen 🙂
label
Feb 8, 2019
nim-odoo
force-pushed the
odoo-dev:12.0-opw-1938570-hr_expense-nim
branch
to
60fe62f
Feb 8, 2019
nim-odoo
changed the title
[FIX] hr_expense: multi-currency
[WIP][FIX] hr_expense: multi-currency
Feb 8, 2019
This comment has been minimized.
This comment has been minimized.
Test necessary |
nim-odoo
added
the
OE
label
Feb 8, 2019
nim-odoo
requested a review
from
kebeclibre
Feb 8, 2019
This comment has been minimized.
This comment has been minimized.
@kebeclibre would you mind sharing your opinion? Before the fix: https://screenshots.firefox.com/X91L4ANrHobH3WJX/localhost |
This comment has been minimized.
This comment has been minimized.
Ouch, indeed before the fix doesn't look good.
I'd also recommend to write some tests |
nim-odoo
force-pushed the
odoo-dev:12.0-opw-1938570-hr_expense-nim
branch
2 times, most recently
from
7c0ad69
to
2087a1f
Feb 11, 2019
nim-odoo
changed the title
[WIP][FIX] hr_expense: multi-currency
[FIX] hr_expense: multi-currency
Feb 11, 2019
nim-odoo
self-assigned this
Feb 11, 2019
nim-odoo
force-pushed the
odoo-dev:12.0-opw-1938570-hr_expense-nim
branch
from
2087a1f
to
33f959e
Feb 11, 2019
robodoo
added
the
CI 🤖
label
Feb 11, 2019
This comment has been minimized.
This comment has been minimized.
robodoo r+ |
pushed a commit
that referenced
this pull request
Feb 11, 2019
This comment has been minimized.
This comment has been minimized.
Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/445803) |
robodoo
added
the
error 🙅
label
Feb 11, 2019
nim-odoo
force-pushed the
odoo-dev:12.0-opw-1938570-hr_expense-nim
branch
from
33f959e
to
ab06e9c
Feb 12, 2019
This comment has been minimized.
This comment has been minimized.
robodoo r+ |
This comment has been minimized.
This comment has been minimized.
I'm sorry, @nim-odoo. This PR is already reviewed, reviewing it again is useless. |
This comment has been minimized.
This comment has been minimized.
robodoo r- |
robodoo
added
CI 🤖
and removed
error 🙅
labels
Feb 12, 2019
This comment has been minimized.
This comment has been minimized.
robodoo r+ |
robodoo
added
the
r+ 👌
label
Feb 12, 2019
pushed a commit
that referenced
this pull request
Feb 12, 2019
robodoo
added
merging 👷
merged 🎉
and removed
merging 👷
labels
Feb 12, 2019
This comment has been minimized.
This comment has been minimized.
Merged, thanks! |
robodoo
closed this
Feb 12, 2019
nim-odoo
deleted the
odoo-dev:12.0-opw-1938570-hr_expense-nim
branch
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nim-odoo commentedFeb 8, 2019
Amount: 100
Tax: 15% Excluded
Not a single AML is correct.
opw-1938570
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr