New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE][REF] website_slides: prepare channel model to eLearning #30985

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tde-banana-odoo
Copy link
Contributor

tde-banana-odoo commented Feb 11, 2019

Purpose of this merge is to prepare eLearning feature by already modifying
channel model.

It includes

  • addition of tag and tag groups on channel, allowing to filter and search;
  • addition of statistics computation on channel, notably tracking completion
    of users;
  • removal of promoted slide feature and addition of specific image field
    on channel;

This merge is related to task ID 1936153 and closes PR #30985. More
generally this merge is linked to ongoing tasks

  • task ID 1902304 (main eLearning task) PR #29876;
  • task ID 1922159 (new user profile and gamification) PR #30514;
  • task ID 1937160 (payment flow and integration with ecommerce) PR #30914;

@robodoo robodoo added the seen 🙂 label Feb 11, 2019

tde-banana-odoo added some commits Feb 1, 2019

[IMP] website_slides: add tags and tag groups on channel
Purpose is to be able to filter, search and categorize channels. Notably
with eLearning in mind there will be more channels as a channel will also be
used to hold lessons.

For that purpose we add a model of tag linked to channels. Those tags are
organized by groups in order to be able to display them using a menu or
a small hierarchy of tags. Displaying a tag group as a specific navigation
element is controlled by a specific field.

Those models will be used to display a new and improved home page for
channels / courses.

This commit is linked to task ID 1936153 and PR #30985.
[IMP] website_slides: improve and add statistics computation
Purpose of this commit is to add some statistics computation on slide.channel
model. We want notably to have a count of views and votes (likes and dislikes)
on channels. Completion is also computed.

Purpose is to be able to search and order channels based on those statistics.
Having stored computed fields for some statistics help achieving that purpose.

Tests are added.

This commit is linked to task ID 1936153 and PR #30985.
[REF] website_slides: remove promoted slide feature, add image and ch…
…annel_type

Purpose of this commit is to clean a bit channel model. Promoted slide
feature is removed as people can already choose an order for a given
channel. Moreover promoted slide will not be used when having a eLearning
display of a channel.

Image field on channels is added as it is not depending on promoted slide
anymore.

To simplify future additions a search-specific template is removed to
have a unique template to display a channel content. It will ease future
merge.

This commit is linked to task ID 1936153 and PR #30985.

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-slides-stats-tde branch from 1c7d6d8 to 0ec13d2 Feb 11, 2019

@tde-banana-odoo tde-banana-odoo changed the title Master slides stats tde [MERGE][REF] website_slides: compute channel statistics Feb 11, 2019

@tde-banana-odoo tde-banana-odoo changed the title [MERGE][REF] website_slides: compute channel statistics [MERGE][REF] website_slides: prepare channel model to eLearning Feb 11, 2019

@C3POdoo C3POdoo added the RD label Feb 11, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor Author

tde-banana-odoo commented Feb 11, 2019

@robodoo r+ rebase-merge

@robodoo robodoo added the r+ 👌 label Feb 11, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 11, 2019

Merge method set to rebase and merge, using the PR as merge commit message

@robodoo robodoo added the CI 🤖 label Feb 11, 2019

robodoo pushed a commit that referenced this pull request Feb 11, 2019

[IMP] website_slides: add tags and tag groups on channel
Purpose is to be able to filter, search and categorize channels. Notably
with eLearning in mind there will be more channels as a channel will also be
used to hold lessons.

For that purpose we add a model of tag linked to channels. Those tags are
organized by groups in order to be able to display them using a menu or
a small hierarchy of tags. Displaying a tag group as a specific navigation
element is controlled by a specific field.

Those models will be used to display a new and improved home page for
channels / courses.

This commit is linked to task ID 1936153 and PR #30985.

robodoo pushed a commit that referenced this pull request Feb 11, 2019

[IMP] website_slides: improve and add statistics computation
Purpose of this commit is to add some statistics computation on slide.channel
model. We want notably to have a count of views and votes (likes and dislikes)
on channels. Completion is also computed.

Purpose is to be able to search and order channels based on those statistics.
Having stored computed fields for some statistics help achieving that purpose.

Tests are added.

This commit is linked to task ID 1936153 and PR #30985.

robodoo pushed a commit that referenced this pull request Feb 11, 2019

[REF] website_slides: remove promoted slide feature, add image and ch…
…annel_type

Purpose of this commit is to clean a bit channel model. Promoted slide
feature is removed as people can already choose an order for a given
channel. Moreover promoted slide will not be used when having a eLearning
display of a channel.

Image field on channels is added as it is not depending on promoted slide
anymore.

To simplify future additions a search-specific template is removed to
have a unique template to display a channel content. It will ease future
merge.

This commit is linked to task ID 1936153 and PR #30985.

robodoo added a commit that referenced this pull request Feb 11, 2019

[MERGE][REF] website_slides: prepare channel model to eLearning
Purpose of this merge is to prepare eLearning feature by already modifying
channel model.

It includes

 * addition of tag and tag groups on channel, allowing to filter and search;
 * addition of statistics computation on channel, notably tracking completion
   of users;
 * removal of promoted slide feature and addition of specific image field
   on channel;

This merge is related to task ID 1936153 and closes PR #30985. More
generally this merge is linked to ongoing tasks

* task ID 1902304 (main eLearning task) PR #29876;
* task ID 1922159 (new user profile and gamification) PR #30514;
* task ID 1937160 (payment flow and integration with ecommerce) PR #30914;
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 11, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 11, 2019

@tde-banana-odoo tde-banana-odoo deleted the odoo-dev:master-slides-stats-tde branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment