New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_expense: multi-currency #30987

Closed
wants to merge 1 commit into
base: saas-11.3
from

Conversation

Projects
None yet
2 participants
@nim-odoo
Copy link
Contributor

nim-odoo commented Feb 11, 2019

  • Set your company to USD
  • Create an expense in EUR:
    Amount: 100
    Tax: 15% Excluded
  • Validate, post the journal entries

It crashes because of a missing .id, but on top of that... not a
single AML is correct.

opw-1938570

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@nim-odoo nim-odoo self-assigned this Feb 11, 2019

@nim-odoo nim-odoo added the OE label Feb 11, 2019

@robodoo robodoo added the seen 🙂 label Feb 11, 2019

[FIX] hr_expense: multi-currency
- Set your company to USD
- Create an expense in EUR:
  Amount: 100
  Tax: 15% Excluded
- Validate, post the journal entries

It crashes because of a missing `.id`, but on top of that... not a
single AML is correct.

opw-1938570

@nim-odoo nim-odoo force-pushed the odoo-dev:saas-11.3-opw-1938570-hr_expense-nim branch from 33d417b to 866b36a Feb 11, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

nim-odoo commented Feb 11, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 11, 2019

[FIX] hr_expense: multi-currency
- Set your company to USD
- Create an expense in EUR:
  Amount: 100
  Tax: 15% Excluded
- Validate, post the journal entries

It crashes because of a missing `.id`, but on top of that... not a
single AML is correct.

opw-1938570

closes #30987
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 11, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 11, 2019

@nim-odoo nim-odoo deleted the odoo-dev:saas-11.3-opw-1938570-hr_expense-nim branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment