New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE][ADD] website{_profile,_slides,_forum,*} : new profile page yayy #30988

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@dbeguin
Copy link
Contributor

dbeguin commented Feb 11, 2019

Purpose of this merge is to provide a completely new and improved user profile
page linked to gamification, slides and forum. Those frontend applications
now heavily rely on website profile and add their own custom content like
channel or forum participation or challenges results. This merge is linked
to the currently under development eLearning feature [1][2].

This merge contains notably

  • review website profile page centralized in a new module : website_profile;
  • move everything that was linked to the profile from website_forum in
    website_profile;
  • properly add forum informations in website_forum through inheritance;
  • add channel / course informations in website_slides through inheritance;

A new bridge module is added that is website_slide_forum. It makes a link
between those two applications. Publishers can create a forum linked to a
course allowing participants to communicate and ask questions related to a
course.

Profile page is contextualized. When coming from a channel informations about
this channel is displayed. Linked forum information is added. When coming from
a specific forum only information related to this forum is displayed.
Otherwise a profile page with aggregated information is displayed.

Some other improvements are done: ranks, karma, badges from gamification are
included in forum and eLearning, 'new badge notifications' mechanism is removed
as email are send, and various other improvements. See sub commits for more
details.

Merge linked to task ID 1922159.

[1] see task ID 1902304 (main eLearning task) PR #29876;
[2] see task ID 1936153 (new homepage for slides) PR #30770;

@robodoo robodoo added the seen 🙂 label Feb 11, 2019

@dbeguin dbeguin changed the title [IMP] website_profile, _forum, _slides, _slides_forum : review website_profile page and add slides info [IMP][ADD] website_profile, _forum, _slides, _slides_forum : review website_profile page and add slides info Feb 11, 2019

@dbeguin dbeguin requested a review from tde-banana-odoo Feb 11, 2019

@dbeguin dbeguin force-pushed the odoo-dev:master-elearning-website-profile-dbe branch from 9285dce to f50f103 Feb 11, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

[ADD] website_profile : add profile page template for website modules
Move Profile part from website_forum into this module in order to be usable in other modules
(like website_slides) that will depend of this module.

Applies gamification.ranks on website_profile page. Show the current rank and the next rank
but also the progression until the next rank. Adds also an 'about rank' page to allow users to know
more about available ranks.

This goal here is to make the profile page more modular and to allow other modules to add informations
or modify easily link or part of profile page in order to be specifically contextualised
for the module in question.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

[IMP] website_slides : use website_profile page template and adds web…
…site_slides specific information

Adds slides ands slide.channels specific information (courses) into the website_profile template page.

As in website_forum, adds the 'cross slides' page and route, that becomes the standard call.
As there can be more than one slide.channel,nthe profile page shows everything linked to every slide.channel,
except if the channel_id is given in url arguments.
The old route have been kept for backward compatibility reasons.

Adds the 'Go to eLearning' button in the 'new rank reached' mail to encourage the users to continue
to be active on the eLearning platform as well, to gain more karma point and improve there rank.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

[REF] website_forum : use website_profile templates and adds forum sp…
…ecific information

Adds forum specific information into the website_profile template page.
Removes everything linked to profile that is already in website_profile module to avoid duplicates.

Adds the 'cross forum' page and route, that becomes the standard call. As there can be more than one forum,
the profile page shows everything linked to every forum, except if the forum id is given in url arguments.
The old route have been kept for backward compatibility reasons.

Adds the 'Go to forum' button in the 'new rank reached' mail to encourage the users to continue
to be active on the forum as well, to gain more karma point and improve there rank.

Image rpc calls have been reviewed for profile page part to use only the standard way to get image
-> web/image/model_name/id/image_size

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

[ADD] website_slides_forum : Allow to create forum on a course
Adds the mega power to make Super Saiyan fusion between website_slides and website_forum
A slide.channel can now be linked to a forum to allow users to discuss about their courses.

Overrides the slides profile routes to include the potiential linked forum.
the profile page displays now all the information of a specific channel with, also, all the
information of the linked channel. If no channle is specified, the slide profile page shows
every thing (information about all channel and information about all forum LINKED to channels).
If the generic profile template page is called, everything is displayed, all forum and all channels.

Task ID : 1922159
PR odoo#30988

@C3POdoo C3POdoo added the RD label Feb 11, 2019

res = super(Users, self).get_gamification_redirection_data()
res.append({
'url': '/slides',
'label': 'Go to Elearning'

This comment has been minimized.

@mreficent

mreficent Feb 11, 2019

Contributor

eLearning or E-learning, right? 🤔

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

eLearning !

@tde-banana-odoo
Copy link
Contributor

tde-banana-odoo left a comment

First technical review (mainly profile + slides_profile).

def _prepare_user_values(self, **kwargs):
values = {
'user': request.env.user,
'is_public_user': request.env.user.id == request.website.user_id.id,

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

Small note: we could use website.is_public_user()


@http.route(['/profile/user/<int:user_id>'], type='http', auth="public", website=True)
def open_user(self, user_id=0, **post):
# isn't that a security hole ?

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

It is. I would at least in profile display on website_published users. I would also display only users with at least one karma point, meaning they participated to forum / slide somehow.

We could think of a hook method to generate a domain that addons can call / customize. Maybe a _check_user_profile_access method to inherit ?

return values

@http.route(['/profile/user/<int:user_id>'], type='http', auth="public", website=True)
def open_user(self, user_id=0, **post):

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

Naming: def view_user_profile ?

return request.render("website_profile.user_detail_main", values)

@http.route('/profile/edit', type='http', auth="user", website=True)
def edit_profile(self, **kwargs):

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

Naming: def view_user_profile_edition ? As it does not edit a profile, it just display the form in order to edit a profile.

return werkzeug.utils.redirect("/profile/user/%d" % user.id)

@http.route('/profile/ranks', type='http', auth="public", website=True)
def ranks(self, **searches):

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

**kwargs ? It doe snot support search if I am not wrong, having kwargs is useful notably for debug mode but that's all I think.


# Users with high karma can see users with karma <= 0 for
# moderation purposes, IFF they have posted something (see below)
if (not user or (user.karma < 1 and current_user.karma < channel.karma_unlink_all)):

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

Post-commented thingy: this is an example of why we should have a unique check method to access a user profile so that we don't have custom implementation in various controllers :) .

<?xml version="1.0" ?>
<odoo>
<data>
<template id="profile_header" name="Slides Profile Header">

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

Guidelining note (check other templates): define on a one liner to save indentation :) . It is easier to read / maintain.

else:
forums = request.env['forum.forum'].search([])

values = {

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

Same as for slides (in short): use existing preparation methods :) .

@@ -46,8 +46,111 @@
<div t-field="forum.welcome_message"/>
</div>

<div class="container mt16 mb32 o_wforum_navbar_container">
<div class="navbar navbar-expand-md navbar-light">
<div class="container mt16 mb32 ">

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

Why this big "seems to be a code move" ?

This comment has been minimized.

@dbeguin

dbeguin Feb 11, 2019

Author Contributor

I had to make the nav header a separate template to call it in here but also in forum_user_profile_main template.

class Forum(models.Model):
_inherit = 'forum.forum'

slide_channel_id = fields.Many2one('slide.channel', 'Course')

This comment has been minimized.

@tde-banana-odoo

tde-banana-odoo Feb 11, 2019

Contributor

Main issue: handle privaty / security as I don't think forums have real security checks. This should be clarified.

@dbeguin dbeguin force-pushed the odoo-dev:master-elearning-website-profile-dbe branch from f50f103 to 0429e48 Feb 11, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

[ADD] website_profile : add profile page template for website modules
Move Profile part from website_forum into this module in order to be usable in other modules
(like website_slides) that will depend of this module.

Applies gamification.ranks on website_profile page. Show the current rank and the next rank
but also the progression until the next rank. Adds also an 'about rank' page to allow users to know
more about available ranks.

This goal here is to make the profile page more modular and to allow other modules to add informations
or modify easily link or part of profile page in order to be specifically contextualised
for the module in question.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

[REF] website_forum : use website_profile templates and adds forum sp…
…ecific information

Adds forum specific information into the website_profile template page.
Removes everything linked to profile that is already in website_profile module to avoid duplicates.

Adds the 'cross forum' page and route, that becomes the standard call. As there can be more than one forum,
the profile page shows everything linked to every forum, except if the forum id is given in url arguments.
The old route have been kept for backward compatibility reasons.

Adds the 'Go to forum' button in the 'new rank reached' mail to encourage the users to continue
to be active on the forum as well, to gain more karma point and improve there rank.

Image rpc calls have been reviewed for profile page part to use only the standard way to get image
-> web/image/model_name/id/image_size

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

[IMP] website_slides : use website_profile page template and adds web…
…site_slides specific information

Adds slides ands slide.channels specific information (courses) into the website_profile template page.

As in website_forum, adds the 'cross slides' page and route, that becomes the standard call.
As there can be more than one slide.channel,nthe profile page shows everything linked to every slide.channel,
except if the channel_id is given in url arguments.
The old route have been kept for backward compatibility reasons.

Adds the 'Go to eLearning' button in the 'new rank reached' mail to encourage the users to continue
to be active on the eLearning platform as well, to gain more karma point and improve there rank.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 11, 2019

[ADD] website_slides_forum : Allow to create forum on a course
Adds the mega power to make Super Saiyan fusion between website_slides and website_forum
A slide.channel can now be linked to a forum to allow users to discuss about their courses.

Overrides the slides profile routes to include the potiential linked forum.
the profile page displays now all the information of a specific channel with, also, all the
information of the linked channel. If no channle is specified, the slide profile page shows
every thing (information about all channel and information about all forum LINKED to channels).
If the generic profile template page is called, everything is displayed, all forum and all channels.

Task ID : 1922159
PR odoo#30988

@dbeguin dbeguin force-pushed the odoo-dev:master-elearning-website-profile-dbe branch from 0429e48 to 56e2975 Feb 12, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[ADD] website_profile : add profile page template for website modules
Move Profile part from website_forum into this module in order to be usable in other modules
(like website_slides) that will depend of this module.

Applies gamification.ranks on website_profile page. Show the current rank and the next rank
but also the progression until the next rank. Adds also an 'about rank' page to allow users to know
more about available ranks.

This goal here is to make the profile page more modular and to allow other modules to add informations
or modify easily link or part of profile page in order to be specifically contextualised
for the module in question.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[REF] website_forum : use website_profile templates and adds forum sp…
…ecific information

Adds forum specific information into the website_profile template page.
Removes everything linked to profile that is already in website_profile module to avoid duplicates.

Adds the 'cross forum' page and route, that becomes the standard call. As there can be more than one forum,
the profile page shows everything linked to every forum, except if the forum id is given in url arguments.
The old route have been kept for backward compatibility reasons.

Adds the 'Go to forum' button in the 'new rank reached' mail to encourage the users to continue
to be active on the forum as well, to gain more karma point and improve there rank.

Image rpc calls have been reviewed for profile page part to use only the standard way to get image
-> web/image/model_name/id/image_size

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[IMP] website_slides : use website_profile page template and adds web…
…site_slides specific information

Adds slides ands slide.channels specific information (courses) into the website_profile template page.

As in website_forum, adds the 'cross slides' page and route, that becomes the standard call.
As there can be more than one slide.channel,nthe profile page shows everything linked to every slide.channel,
except if the channel_id is given in url arguments.
The old route have been kept for backward compatibility reasons.

Adds the 'Go to eLearning' button in the 'new rank reached' mail to encourage the users to continue
to be active on the eLearning platform as well, to gain more karma point and improve there rank.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[ADD] website_slides_forum : Allow to create forum on a course
Adds the mega power to make Super Saiyan fusion between website_slides and website_forum
A slide.channel can now be linked to a forum to allow users to discuss about their courses.

Overrides the slides profile routes to include the potiential linked forum.
the profile page displays now all the information of a specific channel with, also, all the
information of the linked channel. If no channle is specified, the slide profile page shows
every thing (information about all channel and information about all forum LINKED to channels).
If the generic profile template page is called, everything is displayed, all forum and all channels.

Task ID : 1922159
PR odoo#30988

@dbeguin dbeguin force-pushed the odoo-dev:master-elearning-website-profile-dbe branch from 56e2975 to 71b3422 Feb 12, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[REF] website_forum : use website_profile templates and adds forum sp…
…ecific information

Adds forum specific information into the website_profile template page.
Removes everything linked to profile that is already in website_profile module to avoid duplicates.

Adds the 'cross forum' page and route, that becomes the standard call. As there can be more than one forum,
the profile page shows everything linked to every forum, except if the forum id is given in url arguments.
The old route have been kept for backward compatibility reasons.

Adds the 'Go to forum' button in the 'new rank reached' mail to encourage the users to continue
to be active on the forum as well, to gain more karma point and improve there rank.

Image rpc calls have been reviewed for profile page part to use only the standard way to get image
-> web/image/model_name/id/image_size

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[IMP] website_slides : use website_profile page template and adds web…
…site_slides specific information

Adds slides ands slide.channels specific information (courses) into the website_profile template page.

As in website_forum, adds the 'cross slides' page and route, that becomes the standard call.
As there can be more than one slide.channel,nthe profile page shows everything linked to every slide.channel,
except if the channel_id is given in url arguments.
The old route have been kept for backward compatibility reasons.

Adds the 'Go to eLearning' button in the 'new rank reached' mail to encourage the users to continue
to be active on the eLearning platform as well, to gain more karma point and improve there rank.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[ADD] website_slides_forum : Allow to create forum on a course
Adds the mega power to make Super Saiyan fusion between website_slides and website_forum
A slide.channel can now be linked to a forum to allow users to discuss about their courses.

Overrides the slides profile routes to include the potiential linked forum.
the profile page displays now all the information of a specific channel with, also, all the
information of the linked channel. If no channle is specified, the slide profile page shows
every thing (information about all channel and information about all forum LINKED to channels).
If the generic profile template page is called, everything is displayed, all forum and all channels.

Task ID : 1922159
PR odoo#30988

@dbeguin dbeguin force-pushed the odoo-dev:master-elearning-website-profile-dbe branch from 71b3422 to 638ec17 Feb 12, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 12, 2019

[ADD] website_profile : add profile page template for website modules
Move Profile part from website_forum into this module in order to be usable in other modules
(like website_slides) that will depend of this module.

Applies gamification.ranks on website_profile page. Show the current rank and the next rank
but also the progression until the next rank. Adds also an 'about rank' page to allow users to know
more about available ranks.

This goal here is to make the profile page more modular and to allow other modules to add informations
or modify easily link or part of profile page in order to be specifically contextualised
for the module in question.

Task ID : 1922159
PR odoo#30988
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

tde-banana-odoo commented Feb 14, 2019

@robodoo r+ rebase-merge

@robodoo robodoo added the r+ 👌 label Feb 14, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 14, 2019

Merge method set to rebase and merge, using the PR as merge commit message

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[IMP] website_slides : use website_profile page template and adds web…
…site_slides specific information

Adds slides ands slide.channels specific information (courses) into the website_profile template page.

As there can be more than one slide.channel,the profile page shows everything linked to every slide.channel,
except if the channel_id is given in url arguments.

Adds the 'Go to eLearning' button in the 'new rank reached' mail to encourage the users to continue
to be active on the eLearning platform as well, to gain more karma point and improve there rank.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[ADD] website_slides_forum : Allow to create forum on a course
Adds the mega power to make Super Saiyan fusion between website_slides and website_forum
A slide.channel can now be linked to a forum to allow users to discuss about their courses.

Overrides the slides profile routes to include the potiential linked forum.
The profile page will display now all the information of a specific channel with, also, all the
information of the linked forum. If no channel is specified, the profile page shows
everything (information about all channel and information about all forum).

Task ID : 1922159
PR odoo#30988

@robodoo robodoo added the CI 🤖 label Feb 14, 2019

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[IMP] gamification, website_forum : apply various improvements
- add menu to configure ranks in gamification tools because was missing
- move admin karma data in gamification : karma linked to gamification
  and not forum anymore
- fix rank computation : next_rank_id could never been recomputed correctly
  if rank are created in a karma ascending order.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[ADD] website_profile : add profile page template for website modules
Move Profile part from website_forum into this module in order to be usable in other modules
(like website_slides) that will depend of this module.

Applies gamification.ranks on website_profile page. Show the current rank and the next rank
but also the progression until the next rank. Adds also an 'about rank' page to allow users to know
more about available ranks.

The goal here is to make the profile page more modular and to allow other modules to add informations
or modify easily link or part of profile page in order to be specifically contextualised
for the module in question.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[IMP] website_slides : use website_profile page template and adds web…
…site_slides specific information

Adds slides ands slide.channels specific information (courses) into the website_profile template page.

As there can be more than one slide.channel,the profile page shows everything linked to every slide.channel,
except if the channel_id is given in url arguments.

Adds the 'Go to eLearning' button in the 'new rank reached' mail to encourage the users to continue
to be active on the eLearning platform as well, to gain more karma point and improve there rank.

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[REF] website_forum : use website_profile templates and adds forum sp…
…ecific information

Adds forum specific information into the website_profile template page.
Removes everything linked to profile that is already in website_profile module to avoid duplicates.

As there can be more than one forum, the profile page shows everything linked to every forum,
except if the forum id is given in url arguments.
The old route (forum/forum-1/user/user_id) have been kept for backward compatibility reasons.

Adds the 'Go to forum' button in the 'new rank reached' mail to encourage the users to continue
to be active on the forum as well, to gain more karma point and improve there rank.

Image rpc calls have been reviewed for profile page part to use only the standard way to get image
-> web/image/model_name/id/image_size

Task ID : 1922159
PR odoo#30988

dbeguin added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[ADD] website_slides_forum : Allow to create forum on a course
Adds the mega power to make Super Saiyan fusion between website_slides and website_forum
A slide.channel can now be linked to a forum to allow users to discuss about their courses.

Overrides the slides profile routes to include the potiential linked forum.
The profile page will display now all the information of a specific channel with, also, all the
information of the linked forum. If no channel is specified, the profile page shows
everything (information about all channel and information about all forum).

Task ID : 1922159
PR odoo#30988

robodoo pushed a commit that referenced this pull request Feb 14, 2019

[IMP] gamification, website_forum : apply various improvements
- add menu to configure ranks in gamification tools because was missing
- move admin karma data in gamification : karma linked to gamification
  and not forum anymore
- fix rank computation : next_rank_id could never been recomputed correctly
  if rank are created in a karma ascending order.

Task ID : 1922159
PR #30988

robodoo pushed a commit that referenced this pull request Feb 14, 2019

[ADD] website_profile : add profile page template for website modules
Move Profile part from website_forum into this module in order to be usable in other modules
(like website_slides) that will depend of this module.

Applies gamification.ranks on website_profile page. Show the current rank and the next rank
but also the progression until the next rank. Adds also an 'about rank' page to allow users to know
more about available ranks.

The goal here is to make the profile page more modular and to allow other modules to add informations
or modify easily link or part of profile page in order to be specifically contextualised
for the module in question.

Task ID : 1922159
PR #30988

robodoo pushed a commit that referenced this pull request Feb 14, 2019

[REF] website_forum : use website_profile templates and adds forum sp…
…ecific information

Adds forum specific information into the website_profile template page.
Removes everything linked to profile that is already in website_profile module to avoid duplicates.

As there can be more than one forum, the profile page shows everything linked to every forum,
except if the forum id is given in url arguments.
The old route (forum/forum-1/user/user_id) have been kept for backward compatibility reasons.

Adds the 'Go to forum' button in the 'new rank reached' mail to encourage the users to continue
to be active on the forum as well, to gain more karma point and improve there rank.

Image rpc calls have been reviewed for profile page part to use only the standard way to get image
-> web/image/model_name/id/image_size

Task ID : 1922159
PR #30988

robodoo pushed a commit that referenced this pull request Feb 14, 2019

[IMP] website_slides : use website_profile page template and adds web…
…site_slides specific information

Adds slides ands slide.channels specific information (courses) into the website_profile template page.

As there can be more than one slide.channel,the profile page shows everything linked to every slide.channel,
except if the channel_id is given in url arguments.

Adds the 'Go to eLearning' button in the 'new rank reached' mail to encourage the users to continue
to be active on the eLearning platform as well, to gain more karma point and improve there rank.

Task ID : 1922159
PR #30988

robodoo pushed a commit that referenced this pull request Feb 14, 2019

[ADD] website_slides_forum : Allow to create forum on a course
Adds the mega power to make Super Saiyan fusion between website_slides and website_forum
A slide.channel can now be linked to a forum to allow users to discuss about their courses.

Overrides the slides profile routes to include the potiential linked forum.
The profile page will display now all the information of a specific channel with, also, all the
information of the linked forum. If no channel is specified, the profile page shows
everything (information about all channel and information about all forum).

Task ID : 1922159
PR #30988

robodoo added a commit that referenced this pull request Feb 14, 2019

[MERGE][ADD] website{_profile,_slides,_forum,*} : new profile page yayy
Purpose of this merge is to provide a completely new and improved user profile
page linked to gamification, slides and forum. Those frontend applications
now heavily rely on website profile and add their own custom content like
channel or forum participation or challenges results. This merge is linked
to the currently under development eLearning feature [1][2].

This merge contains notably

 * review website profile page centralized in a new module : website_profile;
 * move everything that was linked to the profile from website_forum in
   website_profile;
 * properly add forum informations in website_forum through inheritance;
 * add channel / course informations in website_slides through inheritance;

A new bridge module is added that is website_slide_forum. It makes a link
between those two applications. Publishers can create a forum linked to a
course allowing participants to communicate and ask questions related to a
course.

Profile page is contextualized. When coming from a channel informations about
this channel is displayed. Linked forum information is added. When coming from
a specific forum only information related to this forum is displayed.
Otherwise a profile page with aggregated information is displayed.

Some other improvements are done: ranks, karma, badges from gamification are
included in forum and eLearning, 'new badge notifications' mechanism is removed
as email are send, and various other improvements. See sub commits for more
details.

Merge linked to task ID 1922159.

[1] see task ID 1902304 (main eLearning task) PR #29876;
[2] see task ID 1936153 (new homepage for slides) PR #30770;

closes #30988
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 14, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 14, 2019

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[IMP] gamification, website_slides: add challenges in slides and impr…
…ove ranks

Purpose of this commit is to add challenges related to slide / elearning
module. 5 new challenges with their badges are added. Commit linked to
eLearning tasks [1][2]

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Thibault Delavallee <tde@odoo.com>

[1] new homepage task: ID 1936153 and PR odoo#30770
[2] new user profile / gamification task: ID 1922159 and PR odoo#30514 and odoo#30988

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[IMP] gamification, website_slides: add challenges in slides and impr…
…ove ranks

Purpose of this commit is to add challenges related to slide / elearning
module. 5 new challenges with their badges are added. Commit linked to
eLearning tasks [1][2]

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Thibault Delavallee <tde@odoo.com>

[1] new homepage task: ID 1936153 and PR odoo#30770
[2] new user profile / gamification task: ID 1922159 and PR odoo#30514 and odoo#30988

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 14, 2019

[IMP] gamification, website_slides: add challenges in slides and impr…
…ove ranks

Purpose of this commit is to add challenges related to slide / elearning
module. 5 new challenges with their badges are added. Portal user partner
is now also published to have bioutifoul demo data. Commit linked to
eLearning tasks [1][2]

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Thibault Delavallee <tde@odoo.com>

[1] new homepage task: ID 1936153 and PR odoo#30770
[2] new user profile / gamification task: ID 1922159 and PR odoo#30514 and odoo#30988

robodoo pushed a commit that referenced this pull request Feb 14, 2019

[IMP] gamification, website_slides: add challenges in slides and impr…
…ove ranks

Purpose of this commit is to add challenges related to slide / elearning
module. 5 new challenges with their badges are added. Portal user partner
is now also published to have bioutifoul demo data. Commit linked to
eLearning tasks [1][2]

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Thibault Delavallee <tde@odoo.com>

[1] new homepage task: ID 1936153 and PR #30770
[2] new user profile / gamification task: ID 1922159 and PR #30514 and #30988

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 15, 2019

[IMP] gamification, website_slides: add challenges in slides and impr…
…ove ranks

Purpose of this commit is to add challenges related to slide / elearning
module. 5 new challenges with their badges are added. Portal user partner
is now also published to have bioutifoul demo data. Commit linked to
eLearning tasks [1][2]

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Thibault Delavallee <tde@odoo.com>

[1] new homepage task: ID 1936153 and PR odoo#30770
[2] new user profile / gamification task: ID 1922159 and PR odoo#30514 and odoo#30988

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 15, 2019

[IMP] gamification, website_slides: add challenges in slides and impr…
…ove ranks

Purpose of this commit is to add challenges related to slide / elearning
module. 5 new challenges with their badges are added. Portal user partner
is now also published to have bioutifoul demo data. Commit linked to
eLearning tasks [1][2]

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Thibault Delavallee <tde@odoo.com>

[1] new homepage task: ID 1936153 and PR odoo#30770
[2] new user profile / gamification task: ID 1922159 and PR odoo#30514 and odoo#30988

tde-banana-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 15, 2019

[IMP] gamification, website_slides: add challenges in slides and impr…
…ove ranks

Purpose of this commit is to add challenges related to slide / elearning
module. 5 new challenges with their badges are added. Portal user partner
is now also published to have bioutifoul demo data. Commit linked to
eLearning tasks [1][2]

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Thibault Delavallee <tde@odoo.com>

[1] new homepage task: ID 1936153 and PR odoo#30770
[2] new user profile / gamification task: ID 1922159 and PR odoo#30514 and odoo#30988

robodoo pushed a commit that referenced this pull request Feb 15, 2019

[IMP] gamification, website_slides: add challenges in slides and impr…
…ove ranks

Purpose of this commit is to add challenges related to slide / elearning
module. 5 new challenges with their badges are added. Portal user partner
is now also published to have bioutifoul demo data. Commit linked to
eLearning tasks [1][2]

Co-Authored-By: David Beguin <dbe@odoo.com>
Co-Authored-By: Thibault Delavallee <tde@odoo.com>

[1] new homepage task: ID 1936153 and PR #30770
[2] new user profile / gamification task: ID 1922159 and PR #30514 and #30988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment