/odoo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] repair: Hide lot_id when product is not tracked #30993

Open
wants to merge 1 commit into
base: master
from
+3 −2

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
CI 🤖 RD seen 🙂
Projects
None yet
Milestone
No milestone
3 participants
@aprieels @robodoo @C3POdoo
@aprieels
Copy link
Contributor

aprieels commented Feb 11, 2019

Remove unnecessary field when product is not tracked

Linked to odoo/enterprise#3515

TaskId: 1909413

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 11, 2019

@C3POdoo C3POdoo added the RD label Feb 11, 2019

@robodoo robodoo added the CI 🤖 label Feb 11, 2019

@aprieels aprieels force-pushed the odoo-dev:master-after-sales-anp branch from decc4e3 to 3d171a3 Feb 15, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 15, 2019

@aprieels aprieels force-pushed the odoo-dev:master-after-sales-anp branch from 3d171a3 to 2e0a96d Feb 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 18, 2019

@aprieels
[IMP] repair: Hide lot_id and do not systematically reset lot_id 
- Hide lot_id field when product is not tracked
- There was an onchange on the product_id that systematically set the lot_id to `False`.
When giving default values for the lot_id and product_id through the context,
the default value of the lot_id would be overwriten by the onchange.
To fix this, we only reset the lot_id when it is inconsistent with the product_id.

TaskId: 1909413
Loading status checks…
1f81b34

@aprieels aprieels force-pushed the odoo-dev:master-after-sales-anp branch from 2e0a96d to 1f81b34 Feb 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment