Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_timesheet: hooks in project_create_sale_order #31047

Conversation

Projects
None yet
4 participants
@alexey-pelykh
Copy link
Contributor

alexey-pelykh commented Feb 13, 2019

Description of the issue/feature this PR addresses:
Refactor code a bit to split it by methods that can be overriden. These changes would allow to introduce additional billable types.

Current behavior before PR:
Impossible to define additional billable configuration for Sale Order

Desired behavior after PR is merged:
Possible to define additional billable configuration for Sale Order

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@alexey-pelykh

This comment has been minimized.

Copy link
Contributor Author

alexey-pelykh commented Feb 22, 2019

@jem-odoo this one breaks large method into pieces

@mart-e mart-e requested a review from jem-odoo Mar 13, 2019

@mart-e mart-e added the Services label Mar 13, 2019

@jem-odoo

This comment has been minimized.

Copy link
Contributor

jem-odoo commented Mar 20, 2019

Hello, can you rebase and add a proper commit message to explain why you want to do that changes. Otherwise, code looks okay.
Thanks .

@alexey-pelykh alexey-pelykh force-pushed the brainbeanapps:imp-sale_timesheet-action_create_sale_order_hook branch from 870a27c to e74aef6 Mar 20, 2019

@robodoo robodoo removed the CI 🤖 label Mar 20, 2019

@alexey-pelykh

This comment has been minimized.

Copy link
Contributor Author

alexey-pelykh commented Mar 20, 2019

@jem-odoo I've updated the PR description. This change would allow to extend Odoo with module that introduces additional billing type, e.g. employee_job_rate or similar.

@jem-odoo jem-odoo self-assigned this Mar 20, 2019

@robodoo robodoo added the CI 🤖 label Mar 20, 2019

@alexey-pelykh

This comment has been minimized.

Copy link
Contributor Author

alexey-pelykh commented Apr 1, 2019

@jem-odoo what are next steps with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.