Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] product: corrected pricelist on product variant #31136

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@hdh-odoo
Copy link
Contributor

commented Feb 15, 2019

Description of the issue/feature this PR addresses:

  • Task: https://www.odoo.com/web?#id=1870321&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
  • Pad: https://pad.odoo.com/p/r.42d005ceafdb5aa2fc2050eb0e0227f3
    In Product Pricelist:
    -Removed "product variant" option from "create pricelist item" form.
    -The field "product variant" was previously made visible by selecting "product variant" option. It'll now be made visible on selecting product option; along with "product" field.
    -Field "product" is now made required so that when user creates a variant of some product, it'll connect itself to given product.
    In Product template:
    -Put filters to show only products that can be sold.
    -Put filter to show product variants of selected product only.
    In product variant:
    -Put filters to show only products that can be sold.
    -Previously all the records of given product were shown in "sales" tab of product variant. now, only records of given variant will be shown.
    -Previously records created via "sales" tab of given variant weren't being created in "pricelist". Corrected that.
    Test cases:
    -As the option "product variant" has been removed from model itself, It had to be removed from test cases too.

Current behavior before PR:
-pricelist on product variant shows all records

Desired behavior after PR is merged:
-pricelist on product will show only records that belong to that particular variant

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 15, 2019

@C3POdoo C3POdoo added the RD label Feb 15, 2019

@robodoo robodoo added the CI 🤖 label Feb 15, 2019

@hdh-odoo hdh-odoo force-pushed the odoo-dev:master-product-variant-pricelist-improvement-hdh branch Feb 26, 2019

@robodoo robodoo removed the CI 🤖 label Feb 26, 2019

@hdh-odoo hdh-odoo force-pushed the odoo-dev:master-product-variant-pricelist-improvement-hdh branch 4 times, most recently Feb 26, 2019

@robodoo robodoo added the CI 🤖 label Feb 27, 2019

@hdh-odoo hdh-odoo force-pushed the odoo-dev:master-product-variant-pricelist-improvement-hdh branch Feb 28, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 28, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-product-variant-pricelist-improvement-hdh branch 3 times, most recently Mar 1, 2019

@robodoo robodoo added the CI 🤖 label Mar 1, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-product-variant-pricelist-improvement-hdh branch to e1d2777 Mar 13, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 13, 2019

@hdh-odoo hdh-odoo force-pushed the odoo-dev:master-product-variant-pricelist-improvement-hdh branch from e1d2777 to 326d21d Mar 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 25, 2019

[IMP] product: corrected pricelist on product variant
current Behaviour:
==================

Currently there is no way to set fix price on product variant when Multiple prices per product.
if we add on variant it's directly applied on template(all variant)

Case For Product Template :
   - If user put a fix price on the product (template) and then try to check the product, he will find a line with that fix price on the "Sales" tab "Pricing" section, now if the current user tries to change this price he/she can easily change it, untimately the current user has the information that the product has some pricelist on it and its clearly visible here.

Case For Product Variants :
   - If User put a fix prices on the product variants and then try to check any product variant, he will not find any line with that fix price on the "Sales" tab "Pricing" section, so now if the product manager wants to change the price which is set by the pricelist (fixed price), he/she does not have a clue what is the price..

Fixed in brach:
    -In Product Pricelist(Prices computed from formulas):
        -Remove the product variant option. Keep only 3 radio (Global, Category and Porduct)
        -when 'product' is selected:
            Product field is mandatory
            Product Variant isn't mandatory(invisible if variant is disabled)
	-Put filters to show only products that can be sold.
	-put filter to show product variants of selected product only.

    - In Multiple prices per product:
        - Able to add pricelist only for single variant.

    - As the option "product variant" has been removed from model itself, It had to be removed from test cases too.

Related Task ID : 1870321

@hdh-odoo hdh-odoo force-pushed the odoo-dev:master-product-variant-pricelist-improvement-hdh branch from 326d21d to e0c5f37 Mar 26, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.