Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] base,doc: re-add consolidation feature to gantt view #31159

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@dmo-odoo
Copy link
Contributor

dmo-odoo commented Feb 15, 2019

No description provided.

@robodoo robodoo added the seen 🙂 label Feb 15, 2019

@C3POdoo C3POdoo added the RD label Feb 15, 2019

@robodoo robodoo added the CI 🤖 label Feb 15, 2019

doc/reference/views.rst Outdated
``consolidation``
field name to display consolidation value in record cell
``consolidation_max``
dictionary with the "group by" field as key and the maximum consolidation

This comment has been minimized.

@aab-odoo

aab-odoo Feb 15, 2019

Contributor

dictionnary

doc/reference/views.rst Outdated
The dictionnary definition must use double-quotes, ``{'user_id': 100}`` is
not a valid value
``consolidation_exclude``
name of the field that describe if the task has to be excluded

This comment has been minimized.

@aab-odoo

aab-odoo Feb 15, 2019

Contributor

describes

doc/reference/views.rst Outdated

.. warning::
The dictionnary definition must use double-quotes, ``{'user_id': 100}`` is
not a valid value

This comment has been minimized.

@aab-odoo

aab-odoo Feb 15, 2019

Contributor

do we really need to add this constraint?

@dmo-odoo dmo-odoo force-pushed the odoo-dev:master-gantt-dmo branch Feb 16, 2019

@robodoo robodoo removed the CI 🤖 label Feb 16, 2019

@dmo-odoo

This comment has been minimized.

Copy link
Contributor Author

dmo-odoo commented Feb 16, 2019

@aab-odoo I just put back what was there without actually checking it since we did keep all the same features. Thanks for the check, it is now fixed. I think the warning is useful though, because the value is parsed in json and I personally faced the issue of mixing up the quotes and double quotes... ^^'

@robodoo robodoo added the CI 🤖 label Feb 16, 2019

@dmo-odoo dmo-odoo force-pushed the odoo-dev:master-gantt-dmo branch to 6a255ed Feb 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 18, 2019

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Feb 18, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Feb 18, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 18, 2019

Linked pull request(s) odoo/enterprise#3656 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Feb 18, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 18, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.