Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_payroll: use calendar as default view #31161

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@dmo-odoo
Copy link
Contributor

dmo-odoo commented Feb 15, 2019

No description provided.

[FIX] hr_payroll: use calendar as default view
The webclient doesn't handle a non-existing view as the default
view. However, it must handle it correctly if it is not the
default one since it does it for mrp.production already.

@robodoo robodoo added the seen 🙂 label Feb 15, 2019

@dmo-odoo

This comment has been minimized.

Copy link
Contributor Author

dmo-odoo commented Feb 15, 2019

@aab-odoo This is rather blocking for the freeze as there is currently a crash in the "click all" test because of this. It's funny because the webclient has no issue handling a non-existing view (gantt) in the list of possible views for an action (it does it for mrp.production), but it crashes if it is specifically the default... ^^'

Post freeze, if @apr-odoo Odoo really wants to have the gantt view as default when Enterprise is installed and we don't want to create a bridge module just for that, maybe we could change the webclient such that, if the first view of the action doesn't exist, it defaults on the second one ?

@robodoo robodoo added the CI 🤖 label Feb 15, 2019

@C3POdoo C3POdoo added the RD label Feb 15, 2019

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Feb 15, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 15, 2019

[FIX] hr_payroll: use calendar as default view
The webclient doesn't handle a non-existing view as the default
view. However, it must handle it correctly if it is not the
default one since it does it for mrp.production already.

closes #31161

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Feb 15, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 15, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.