Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_holidays: leave_type_request_unit field is declared twice #31162

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
3 participants
@mreficent
Copy link
Contributor

mreficent commented Feb 15, 2019

Description of the issue/feature this PR addresses:

The leave_type_request_unit field of hr.leave model is declared twice. Here L117 and here L175.

Current behavior before PR:
The leave_type_request_unit field of hr.leave model is declared twice.

Desired behavior after PR is merged:
The leave_type_request_unit field of hr.leave model is declared once.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@mreficent

This comment has been minimized.

Copy link
Contributor Author

mreficent commented Mar 6, 2019

@RomainLibert

This comment has been minimized.

Copy link
Contributor

RomainLibert commented Mar 6, 2019

@robodoo rebase-ff r+

Thanks

@robodoo robodoo added the r+ 👌 label Mar 6, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 6, 2019

Merge method set to rebase and fast-forward

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 6, 2019

Merged, thanks!

@mreficent mreficent deleted the Eficent:12.0-hr_holidays-delete_repeated_field branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.