Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_slides: fix computation of completed courses #31188

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tde-banana-odoo
Copy link
Contributor

tde-banana-odoo commented Feb 18, 2019

No description provided.

@robodoo robodoo added the seen 🙂 label Feb 18, 2019

@C3POdoo C3POdoo added the RD label Feb 18, 2019

@robodoo robodoo added the CI 🤖 label Feb 18, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-elearning-fixes-tde-1 branch Feb 18, 2019

@robodoo robodoo removed the CI 🤖 label Feb 18, 2019

tde-banana-odoo added some commits Feb 18, 2019

[REF] website_slides: use mixin.image on channel and slide models
This recently introduced mixin allows to hide complexity of defining, using
and resizing images. Let us use it in channel and image model.

This commit is linked to task ID 1941250 and PR #31188.
[IMP] website_slides: fix and improve homepage
 * display a Completed badge for completed courses;
 * display a cropped image for channel image card;
 * various small code cleaning;

cleanup: homepage: use float_time widget + some cleaning in footer + add completed badge

cleanup: navigation and display of channel to be a bit more responsive

This commit is linked to task ID 1941250 and PR #31188.
[REF] website_slide: rename statistics fields on channel and category…
… models

Purpose is to reduce model naming complexity. Currently you have: slide_type
<type>, and related statistics on channel and category nbr_<type>s with a
trailing and error-prone s. Let us remove the trailing s to reduce complexity
of code reading. Some code cleaning in statistics computation is also done.

This commit also move slide.category code in its own file to fit guidelines.

This commit is linked to task ID 1941250 and PR #31188.

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-elearning-fixes-tde-1 branch to 40256be Feb 18, 2019

@robodoo robodoo added the CI 🤖 label Feb 18, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor Author

tde-banana-odoo commented Feb 20, 2019

Included in #31272 and #31279 .

@tde-banana-odoo tde-banana-odoo deleted the odoo-dev:master-elearning-fixes-tde-1 branch Feb 20, 2019

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.