Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[FIX] sale: configurator option modal change variant #31201
Part 1: Backend
Part 2: Front end
For that part though, there is a huge design problem:
It is understandable given the history of the module, but a proper refactoring
Also, I just noticed, but this is also a problem in 12.0, that the RPC is returning the carousel even when called for the modal, where we don't display the carousel. This has no visual impact, it just makes the RPC a bit slower, so I guess it's not a priority.
Missing modules in commit: sale,sale_management,website_sale
Other than that, I retested what I mentioned and it looks good now. If @qsm-odoo is ok with the last changes, it's ok for me.
I know it's ugly but we have to do with it in 12.0... We'll fix this mess in master after the configurator v2 task.