Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]web: context group by - js #31213

Closed
wants to merge 1 commit into
base: 11.0
from

Conversation

Projects
None yet
4 participants
@mao-odoo
Copy link
Contributor

mao-odoo commented Feb 18, 2019

Depending on the context (group_by or default_group_by),
pyUtils.eval('context', somerawcontext) will return a an object with a
group_by field that is a string or a list of strings (respectivly)

_readGroup & _renderGroupRow were always expecting a list of strings,
which resulted in group_bys on a single letter, which of course didn't
match.

opw-1941273

[FIX]web: context group by - js
Depending on the context (group_by or default_group_by),
pyUtils.eval('context', somerawcontext) will return a an object with a
group_by field that is a string or a list of strings (respectivly)

_readGroup & _renderGroupRow were always expecting a list of strings,
which resulted in group_bys on a single letter, which of course didn't
match.

opw-1941273
@nle-odoo

This comment has been minimized.

Copy link
Contributor

nle-odoo commented Feb 19, 2019

Hi,

Thanks, this helped me to see where the issue came from.

As far as I can tell, the original report was an issue caused by a customization. This fix could have merit in stable if we have more feedback that this is a problematic thing (or there is other way to cause the same issue), so for now I am closing this.

@nle-odoo nle-odoo closed this Feb 19, 2019

@nle-odoo nle-odoo deleted the odoo-dev:11.0-web-context_groupby-string_or_list_my_heart_cannot_choose-mao branch Feb 19, 2019

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.