Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_sale: correct 'border_primary' color #31214

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
3 participants
@qsm-odoo
Copy link
Contributor

qsm-odoo commented Feb 18, 2019

Some elements in the eCommerce are styled using the 'border_primary'
class. The color used by the class is however the wrong one, as it was
set to the odoo purple while it was meant to be the theme primary color.
This commit fixes the color.

Note that BS4 has an equivalent for that class (.border.border-primary)
but as this is a stable fix, it was not changed. It will be adapted in
master with #31147

[FIX] website_sale: correct 'border_primary' color
Some elements in the eCommerce are styled using the 'border_primary'
class. The color used by the class is however the wrong one, as it was
set to the odoo purple while it was meant to be the theme primary color.
This commit fixes the color.

Note that BS4 has an equivalent for that class (.border.border-primary)
but as this is a stable fix, it was not changed. It will be adapted in
master with #31147

@qsm-odoo qsm-odoo self-assigned this Feb 18, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

qsm-odoo commented Feb 18, 2019

pniederlag pushed a commit to pniederlag/odoo that referenced this pull request Feb 18, 2019

[FIX] website_sale: correct 'border_primary' color
Some elements in the eCommerce are styled using the 'border_primary'
class. The color used by the class is however the wrong one, as it was
set to the odoo purple while it was meant to be the theme primary color.
This commit fixes the color.

Note that BS4 has an equivalent for that class (.border.border-primary)
but as this is a stable fix, it was not changed. It will be adapted in
master with odoo#31147

closes odoo#31214
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 18, 2019

Staging failed: ci/runbot on eb3eb82e6a5d71cefeccca24c58700f893a28281 (view more at http://runbot.odoo.com/runbot/build/451749)

@robodoo robodoo added error 🙅 and removed CI 🤖 labels Feb 18, 2019

@xmo-odoo

This comment has been minimized.

Copy link
Collaborator

xmo-odoo commented Feb 19, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 19, 2019

Merged, thanks!

@qsm-odoo qsm-odoo deleted the odoo-dev:12.0-fix-border_primary-qsm branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.