Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account: Fix forward-port of ec25b9d #31218

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
4 participants
@hugho-ad
Copy link
Contributor

hugho-ad commented Feb 18, 2019

since the fix of the forward-port has missed checking the chart template
too
2bba89c

Check the chart template is required because company could have a chart
template and any record at ['account.move.line', 'account.invoice',
'account.payment', 'account.bank.statement'] models

Description of the issue/feature this PR addresses:

Current behavior before PR:
The company still have a chart template
#31217

Desired behavior after PR is merged:
No traceback
image

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

OPW 1942475

[FIX] account: Fix forward-port of ec25b9d
since the fix of the forward-port has missed checking the chart template
too
2bba89c

Check the chart template is required because company could have a chart
template and any record at  ['account.move.line', 'account.invoice',
'account.payment', 'account.bank.statement'] models

@robodoo robodoo added the seen 🙂 label Feb 18, 2019

@robodoo robodoo added the CI 🤖 label Feb 18, 2019

@mart-e mart-e requested review from KangOl and smetl Feb 20, 2019

@smetl

smetl approved these changes Feb 20, 2019

@smetl

This comment has been minimized.

Copy link
Contributor

smetl commented Feb 20, 2019

@qdp-odoo r+ plz

@KangOl

This comment has been minimized.

Copy link
Contributor

KangOl commented Feb 20, 2019

@robodoo robodoo added the r+ 👌 label Feb 20, 2019

robodoo pushed a commit that referenced this pull request Feb 20, 2019

[FIX] account: Fix forward-port of ec25b9d
since the fix of the forward-port has missed checking the chart template
too
2bba89c

Check the chart template is required because company could have a chart
template and any record at  ['account.move.line', 'account.invoice',
'account.payment', 'account.bank.statement'] models

closes #31218

robodoo pushed a commit that referenced this pull request Feb 20, 2019

[FIX] account: Fix forward-port of ec25b9d
since the fix of the forward-port has missed checking the chart template
too
2bba89c

Check the chart template is required because company could have a chart
template and any record at  ['account.move.line', 'account.invoice',
'account.payment', 'account.bank.statement'] models

closes #31218
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/453237)

@KangOl

This comment has been minimized.

Copy link
Contributor

KangOl commented Feb 20, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Feb 20, 2019

robodoo pushed a commit that referenced this pull request Feb 20, 2019

[FIX] account: Fix forward-port of ec25b9d
since the fix of the forward-port has missed checking the chart template
too
2bba89c

Check the chart template is required because company could have a chart
template and any record at  ['account.move.line', 'account.invoice',
'account.payment', 'account.bank.statement'] models

closes #31218
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.