Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master elearning access tde #31239

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tde-banana-odoo
Copy link
Contributor

tde-banana-odoo commented Feb 19, 2019

No description provided.

@robodoo robodoo added the seen 🙂 label Feb 19, 2019

@C3POdoo C3POdoo added the RD label Feb 19, 2019

@robodoo robodoo added the CI 🤖 label Feb 19, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-elearning-access-tde branch Feb 19, 2019

@robodoo robodoo removed the CI 🤖 label Feb 19, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-elearning-access-tde branch 7 times, most recently Feb 19, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-elearning-access-tde branch Feb 19, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-elearning-access-tde branch Feb 19, 2019

tde-banana-odoo and others added some commits Feb 19, 2019

[REF] website_slides: improve and make access options clearer
Purpose is to ensure more advanced use cases are still supported in new
elearning platform in addition to more public use cases. Fields controlling
access are now

 * enroll: who can enroll on course: public (everyone, simply click on join
   button), invite (added by already members) and payment (in bridge with
   website_sale, if SO with product is confirmed);
 * enroll_group_ids: automatically add members of those groups to the channel
   to ease having groups for a given subset of users;
 * visibility: who can see a channel and its slides: public (everyone, it means
   channel is visible on website for example), members (hidden for non members)
 * website_published on channels and slides; non publishers cannot see what
   is not published, whatever other parameters;
 * upload_group_ids: who can upload on a channel;
 * download_security on a slide is completely removed as it makes no sense
   for most slide types;

To ensure a better user experience responsible of a channel is added in its
members. People uploading a slide are now also allowed to read it to avoid
having inconsistency behavior between upload_group_ids and access rules.

Some tests are added.

This commit is linked to task ID 1942836 and PR #31239.

Co-Authored-By: Aurélien Warnon <awa@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
[FIX] website_slides: (temporarily) fix infinite loop
Do not fall into an infinite loop when fetching content of an empty webpage
slide in the newly-introduced fullscreen mode.

This commit is linked to task ID 1942836 and PR #31239.

Co-Authored-By: Aurélien Warnon <awa@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
[FIX] website_slides: set slide as completed only for valid members
Indeed some slides are available for external people if is_preview is set
to True. It indicates slide is available for teasing. It should not be
marked as completed for non members.

This commit is linked to task ID 1942836 and PR #31239.

Co-Authored-By: Aurélien Warnon <awa@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-elearning-access-tde branch to ef5abd5 Feb 19, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor Author

tde-banana-odoo commented Feb 19, 2019

@robodoo r+ rebase-ff

@robodoo robodoo added the r+ 👌 label Feb 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 19, 2019

Merge method set to rebase and fast-forward

@robodoo robodoo added the CI 🤖 label Feb 19, 2019

robodoo pushed a commit that referenced this pull request Feb 19, 2019

[REF] website_slides: improve and make access options clearer
Purpose is to ensure more advanced use cases are still supported in new
elearning platform in addition to more public use cases. Fields controlling
access are now

 * enroll: who can enroll on course: public (everyone, simply click on join
   button), invite (added by already members) and payment (in bridge with
   website_sale, if SO with product is confirmed);
 * enroll_group_ids: automatically add members of those groups to the channel
   to ease having groups for a given subset of users;
 * visibility: who can see a channel and its slides: public (everyone, it means
   channel is visible on website for example), members (hidden for non members)
 * website_published on channels and slides; non publishers cannot see what
   is not published, whatever other parameters;
 * upload_group_ids: who can upload on a channel;
 * download_security on a slide is completely removed as it makes no sense
   for most slide types;

To ensure a better user experience responsible of a channel is added in its
members. People uploading a slide are now also allowed to read it to avoid
having inconsistency behavior between upload_group_ids and access rules.

Some tests are added.

This commit is linked to task ID 1942836 and PR #31239.

Co-Authored-By: Aurélien Warnon <awa@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>

robodoo pushed a commit that referenced this pull request Feb 19, 2019

[FIX] website_slides: (temporarily) fix infinite loop
Do not fall into an infinite loop when fetching content of an empty webpage
slide in the newly-introduced fullscreen mode.

This commit is linked to task ID 1942836 and PR #31239.

Co-Authored-By: Aurélien Warnon <awa@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>

robodoo pushed a commit that referenced this pull request Feb 19, 2019

[FIX] website_slides: set slide as completed only for valid members
Indeed some slides are available for external people if is_preview is set
to True. It indicates slide is available for teasing. It should not be
marked as completed for non members.

This commit is linked to task ID 1942836 and PR #31239.

Co-Authored-By: Aurélien Warnon <awa@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 19, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 19, 2019

@tde-banana-odoo tde-banana-odoo deleted the odoo-dev:master-elearning-access-tde branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.