Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master elearning access tde #31239

Closed
Closed
Diff settings

Always

Just for now

[FIX] website_slides: (temporarily) fix infinite loop

Do not fall into an infinite loop when fetching content of an empty webpage
slide in the newly-introduced fullscreen mode.

This commit is linked to task ID 1942836 and PR #31239.

Co-Authored-By: Aurélien Warnon <awa@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
  • Loading branch information...
tde-banana-odoo and awa-odoo committed Feb 19, 2019
commit 0b97417682615fd419cf12d5edcd7fdeecb76e33
@@ -232,8 +232,10 @@ odoo.define('website_slides.fullscreen', function (require) {
'slide_id': self.slide.id
}
}).then(function(data){
self.slide.htmlContent = data.html_content;
self._renderPlayer();
if (data.html_content) {
self.slide.htmlContent = data.html_content;
self._renderPlayer();
}
})
},
/**
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.