Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] note: display date picker in activity menu #31241

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
4 participants
@Xavier-Do
Copy link
Contributor

Xavier-Do commented Feb 19, 2019

The date picker should be displayed when clicking on the fa-calendar
when creating a note from activity systray.

The test was missing the assertion checking that the date picker was displayed,
but fixing this issue breaks the test. The datepicker looks to be
asynchronously initialized, and the blur event raises an error because of
that. Since it is difficult to test external libs behaviour, this
step is simply removed from the test.

Task: 1942850

[FIX] note: display date picker in activity menu
The date picker should be displayed when clicking on the fa-calendar
when creating a note from activity systray.

The test was missing the assertion checking that the date picker was displayed,
but fixing this issue breaks the test. The datepicker looks to be
asynchronously initialized, and the blur event raises an error because of
that. Since it is difficult to test external libs behaviour, this
step is simply removed from the test.

Task: 1942850

@robodoo robodoo added the seen 🙂 label Feb 19, 2019

@Xavier-Do Xavier-Do requested a review from alexkuhn Feb 19, 2019

@alexkuhn

This comment has been minimized.

Copy link
Contributor

alexkuhn commented Feb 19, 2019

@robodoo robodoo added the r+ 👌 label Feb 19, 2019

@C3POdoo C3POdoo added the RD label Feb 19, 2019

robodoo pushed a commit that referenced this pull request Feb 19, 2019

[FIX] note: display date picker in activity menu
The date picker should be displayed when clicking on the fa-calendar
when creating a note from activity systray.

The test was missing the assertion checking that the date picker was displayed,
but fixing this issue breaks the test. The datepicker looks to be
asynchronously initialized, and the blur event raises an error because of
that. Since it is difficult to test external libs behaviour, this
step is simply removed from the test.

Task: 1942850

closes #31241

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Feb 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 19, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.