Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_holidays: numerical error #31245

Closed
wants to merge 1 commit into
base: 11.0
from

Conversation

Projects
None yet
2 participants
@nim-odoo
Copy link
Contributor

nim-odoo commented Feb 19, 2019

In some exceptional circumstances, the computation of the remaining
leaves might lead to numerical errors, e.g. a very small but non-zero
number (e.g. 10^-17)

This value will be displayed in the name of the leave type because of
the %g used in the string format. To avoid breaking the translation,
we round the value.

opw-1935232

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] hr_holidays: numerical error
In some exceptional circumstances, the computation of the remaining
leaves might lead to numerical errors, e.g. a very small but non-zero
number (e.g. 10^-17)

This value will be displayed in the name of the leave type because of
the `%g` used in the string format. To avoid breaking the translation,
we round the value.

opw-1935232

@robodoo robodoo added the seen 🙂 label Feb 19, 2019

@nim-odoo nim-odoo added the OE label Feb 19, 2019

@nim-odoo nim-odoo self-assigned this Feb 19, 2019

@robodoo robodoo added the CI 🤖 label Feb 19, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

nim-odoo commented Feb 19, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 19, 2019

[FIX] hr_holidays: numerical error
In some exceptional circumstances, the computation of the remaining
leaves might lead to numerical errors, e.g. a very small but non-zero
number (e.g. 10^-17)

This value will be displayed in the name of the leave type because of
the `%g` used in the string format. To avoid breaking the translation,
we round the value.

opw-1935232

closes #31245

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Feb 19, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 19, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 19, 2019

@nim-odoo nim-odoo deleted the odoo-dev:11.0-opw-1935232-leave_zero-nim branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.