Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: pivot unload filter, reset, load another filter #31247

Closed
wants to merge 1 commit into
base: 11.0
from

Conversation

Projects
None yet
4 participants
@kebeclibre
Copy link
Contributor

kebeclibre commented Feb 19, 2019

On a pivot view with a default filter which has columns and row groupbys

Remove the filter
Activate another Filter from favorite which has a column groupby at least

Before this commit, the columns were not displayed in the DOM, though RPC's
and internal data were actually correct
This was because even in that case we considered the changes had been done "in place"
taking the old tree to build the new one for the columns

After this commit, the columns display the group we want

OPW 1935155
When really, we should have recomputed the column tree

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@kebeclibre kebeclibre requested a review from aab-odoo Feb 19, 2019

@robodoo robodoo added the seen 🙂 label Feb 19, 2019

@C3POdoo C3POdoo added the OE label Feb 19, 2019

@robodoo robodoo added the CI 🤖 label Feb 19, 2019

[FIX] web: pivot unload filter, reset, load another filter
On a pivot view with a default filter which has column and row groupbys
Remove the filter
Collapse all columns and rows
Activate another Filter from favorite which has a column groupby at least

Before this commit, the columns were not displayed in the DOM, though RPC's
and internal data were actually correct
This was because we considered the changes had been done "in place"
taking the old tree to build the new one for the columns
when really, we should have recomputed the column tree

After this commit, the columns display the group we want

OPW 1935155

@kebeclibre kebeclibre force-pushed the odoo-dev:11.0-pivot-unload-reload-filter-lpe branch to 0d7ecb4 Feb 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 19, 2019

@aab-odoo

This comment has been minimized.

Copy link
Contributor

aab-odoo commented Feb 20, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Feb 20, 2019

robodoo pushed a commit that referenced this pull request Feb 20, 2019

[FIX] web: pivot unload filter, reset, load another filter
On a pivot view with a default filter which has column and row groupbys
Remove the filter
Collapse all columns and rows
Activate another Filter from favorite which has a column groupby at least

Before this commit, the columns were not displayed in the DOM, though RPC's
and internal data were actually correct
This was because we considered the changes had been done "in place"
taking the old tree to build the new one for the columns
when really, we should have recomputed the column tree

After this commit, the columns display the group we want

OPW 1935155

closes #31247
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 20, 2019

@nle-odoo nle-odoo deleted the odoo-dev:11.0-pivot-unload-reload-filter-lpe branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.