Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: avoid long menu dropdown overflow #31251

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
4 participants
@odony
Copy link
Contributor

odony commented Feb 19, 2019

The Actions/Print dropdowns may overflow the screen in case of very long lists of menu entries, when based solely on the default BS4 styles for dropdown-menu.

This is demonstrated in the following user-provided screenshot:
download 1

The o_dropdown_menu class forces a vertical limit and a scrollbar when this happens, and should be applied to those control-panel dropdowns to prevent this UI glitch.

See also 1c1c089 which adapted dropdowns to BS4.

[FIX] web: avoid long menu dropdown overflow
The Actions/Print dropdowns may overflow the screen in case of very long
lists of menu entries, when based solely on the default BS4 styles for
`dropdown-menu`.

The `o_dropdown_menu` class forces a vertical limit and a scrollbar when
this happens, and should be applied to those control-panel dropdowns to
prevent this UI glitch.

See also 1c1c089 which adapted
dropdowns to BS4.

@odony odony requested review from qsm-odoo and JKE-be Feb 19, 2019

@odony

This comment has been minimized.

Copy link
Contributor Author

odony commented Feb 19, 2019

@qsm-odoo Not sure about any unwanted side-effects for this change?
For some reason these sidebar menus did not have o_dropdown_menu, while others did (the search view dropdown menus, for instance)

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

qsm-odoo commented Feb 20, 2019

From what I see the o_dropdown_menu class is meant to be used by control panel / top menu dropdown, so I suppose that is fine. They will receive a 150px min-width though. And use an ugly calc rule.
@robodoo r+
cc @aab-odoo

@robodoo robodoo added the r+ 👌 label Feb 20, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

qsm-odoo commented Feb 20, 2019

(bug is also there in < 12.0 but maybe we do not have such long menus in standard there ?)

@robodoo robodoo closed this in 3e5ab60 Feb 20, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Feb 20, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.