Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[ADD] account: Invoice residual shall not change with FX differences #31257
Mexican Law requieres to Enterprises make realization entries for the Payables/Receivable in the invoices, and their taxes, and their realization, must be done in separate ways, without mixing them, gains & loss, because according to Income Tax Act the must be treated as interest.
In the following Slides we have the legal justification for having done a separate FX difference Journal Entry and why they are being reconciled in the way we have depicted in this PR.
Slides in Spanish: https://docs.google.com/presentation/d/15E-xUNEIiQ2pWOfJsQ-uEglxhOqgGd1G6LBY_BmqQ2E/edit#slide=id.p5
Having the need to comply with the law in the detailed way we have depicted above. We have encountered with the following issue:
Update: A video has been added to this description for better explanation of the issue.
This procedure has been verified by a third party consultant and has been deemed abiding to law.
Opw & Issue
OPW 1943518 / #31294
Feb 20, 2019
3 times, most recently
Feb 23, 2019
referenced this pull request
Feb 23, 2019
2 times, most recently
Feb 23, 2019
nhomar left a comment
This fix is a HUGE need in MX we have several customers with different sizing asking for such fix, and we are close to close the year here in MX and 2 month of the year for the valuation we are way late with this fix (it took to us a lot of time checking the corner cases and trying to solve with no development).
Can we expedite this review my friends
thanks for the video, the use case is effectively much clearer.
Nevertheless, I don't agree with how you deal with your currency provisioning.
This is at least how we deal with it here (I believe it's True for Belgium, France, Switzerland... maybe the whole Europe?). We have currently a WIP branch to implement this feature, feel free to test and give your feedback on it: odoo/enterprise#3334
To conclude, I don't see any reason to apply such risky changes in the residual amounts computation. Let me know your thoughts
The revaluation is not a report because the user must/need affect accounting.
In other hand @hbto solution is being used for valuation, but the problem is present even if simply the exchange rate goes down forcing the receivable/payable goind down/up in th ecurrency of the transaction when has payments in the currency of the company.
He will explain better, but I think a report is mandatory/necesary (nice for that) but the execution of the revaluation affect the balances and is not just informative.