Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] sale_quotation_builder: warn edit product description #31263

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
2 participants
@nle-odoo
Copy link
Contributor

nle-odoo commented Feb 20, 2019

On the quote builder, we have a description per product that is either:

  • the description of the product on the quotation template
  • the quote_description of the product

and if it is empty we can edit it on the quote builder.

But if we have several of them, we only see several empty editing blocks
without knowing which product it refers to: thus if we removed the line
it could have adverse effects by removing something not related.

With this change, there is an alert when editing that explain each
line description being.

opw-1943009

@nle-odoo nle-odoo added the OE label Feb 20, 2019

@nle-odoo nle-odoo force-pushed the odoo-dev:12.0-sale-quotation-builder-opw-1943009-nle branch Feb 20, 2019

@robodoo robodoo added the seen 🙂 label Feb 20, 2019

@nle-odoo nle-odoo force-pushed the odoo-dev:12.0-sale-quotation-builder-opw-1943009-nle branch Feb 20, 2019

@nle-odoo nle-odoo changed the title [FIX] sale_quotation_builder: [FIX] sale_quotation_builder: warn edit product description Feb 20, 2019

[FIX] sale_quotation_builder: warn edit product description
On the quote builder, we have a description per product that is either:

- the description of the product on the quotation template
- the quote_description of the product

and if it is empty we can edit it on the quote builder.

But if we have several of them, we only see several empty editing blocks
without knowing which product it refers to: thus if we removed the line
it could have adverse effects by removing something not related.

With this change, there is an alert when editing that explain each
line description being.

opw-1943009
closes #31263

@nle-odoo nle-odoo force-pushed the odoo-dev:12.0-sale-quotation-builder-opw-1943009-nle branch to 30d76ed Feb 20, 2019

@robodoo robodoo added the CI 🤖 label Feb 20, 2019

@nle-odoo

This comment has been minimized.

Copy link
Contributor Author

nle-odoo commented Feb 20, 2019

robodoo r+

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Merged, thanks!

@nle-odoo nle-odoo deleted the odoo-dev:12.0-sale-quotation-builder-opw-1943009-nle branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.