Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE] website_slides: various fixes for frontend and first design tweaks #31279

Closed
wants to merge 9 commits into
base: saas-12.2
from

Conversation

Projects
None yet
6 participants
@tde-banana-odoo
Copy link
Contributor

tde-banana-odoo commented Feb 20, 2019

Purpose of this merge is to provide several fixes related to new elearning
application. Those are mainly fixes for front-end templates and first
design improvements / fixes.

See sub commits for more details.

Merge linked to task ID 1941250 and PR #31279.

@C3POdoo C3POdoo added the RD label Feb 20, 2019

@robodoo robodoo removed the CI 🤖 label Feb 20, 2019

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-2 branch 6 times, most recently Feb 20, 2019

tde-banana-odoo and others added some commits Feb 20, 2019

[FIX] website_slides: fix typo
Commit linked to task ID 1941250 and PR #31279.
[IMP] website_slides_*: update manifests
Commit linked to task ID 1941250 and PR #31279.
[FIX] website_slides_survey: put the demo certification into a category
This commit puts the certification slide from the demo data into a category
so that it's correctly displayed on the channel frontend view.

Commit linked to task ID 1941250 and PR #31279.
[IMP] website_slides: fix and improve homepage
Various fixes linked to homepage of courses

 * move channel navigation in its right container, clean its display and
   related templating;
 * display a Completed badge for completed courses;
 * display a cropped image for channel image card in order to avoid blank lines
   around image not having the right aspect ratio;
 * use standard qweb widgets, notably float_time;
 * make header and footer of /slides and /slides/all editable and improve
   their styling;
 * remove old and unused css linked to previous versions of homepage;
 * various small code cleaning;

Commit linked to task ID 1941250 and PR #31279.

Co-Authored-By: Thibault Delavallée <tde@odoo.com>
Co-Authored-By: Stefano Rigano <sri@odoo.com>
[IMP] website_slides: improve homepage navbar design
Force white background + add the default bootstrap shadow. Do not use <h4>
tags to keep the right font-size on mobile. Simplify layout, add a second
navabar to handle content supposed to be moved to the right.

Commit linked to task ID 1941250 and PR #31279.
[IMP] website_slides: do not display channel information and featured…
… slide if search

Commit linked to task ID 1941250 and PR #31279.
[FIX] website_slides: various fixes related to course page
 * remove useless slide management buttons. This commit removes the frontend
   edit/publish/unlink buttons on slide cards (for the 'document' channel view)
   as they were not handled on the backend side.
 * hide slide type filter for documentation channels. The slide type filter
   (including statistics) on the left side of the channel frontend view
   was only handled for channels of type 'documentation'. This commit hides
   the slide type stats/filters if the channel is not of type documentation.
 * display add content/section buttons based on user rights. Fixes two channel
   frontend issues with user rights management:

   * Users that have the right to upload (can_upload field) should have the
    "Add content" button available.
   * The "Add section" button should only be available to website_publisher
     accordingly to ACLs

Commit linked to task ID 1941250 and PR #31279.
[FIX] website_profile: always give access to user to his own profile
The main condition to be able to see a profile is that the user we want to
see the profile is website_published.
But if a new user sign up and wants to access his own profile, he must
get access to his own profile, even if he is (not yet) website_published.

Commit linked to task ID 1941250 and PR #31279.
[FIX] website_slides: add various design and UX fixes
- slidesChannelDropdownSort : dropdown items back to visible (was white on white)
- Featured lesson : change icon to bullhorn instead of + icon
- Pass certification fullscreen button : btn primary
- set max height to fullscreen content to 100% minus header
- Fix 'infographic' slide type image view
- change image for 'Furniture Technical Specifications' course
- fix fullscreen presentation mode: The condition to add the iframe that
  contains the presentation of the document was wrong and, so, never met.
  Those conditions are evaluated in javascript and not in python as it's part
  of t-name template linked to a javascript widget.

Commit linked to task ID 1941250 and PR #31279.

@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:saas-12.2-elearning-fiximp-tde-2 branch to e8a609e Feb 20, 2019

@tde-banana-odoo tde-banana-odoo changed the title [MERGE] website_slides: do stuff [MERGE] website_slides: various fixes for frontend and first design tweaks Feb 20, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor Author

tde-banana-odoo commented Feb 20, 2019

@robodoo r+ rebase-merge

@robodoo robodoo added the r+ 👌 label Feb 20, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Merge method set to rebase and merge, using the PR as merge commit message

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[IMP] website_slides_*: update manifests
Commit linked to task ID 1941250 and PR odoo#31279.

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[FIX] website_slides_survey: put the demo certification into a category
This commit puts the certification slide from the demo data into a category
so that it's correctly displayed on the channel frontend view.

Commit linked to task ID 1941250 and PR odoo#31279.

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[IMP] website_slides: fix and improve homepage
Various fixes linked to homepage of courses

 * move channel navigation in its right container, clean its display and
   related templating;
 * display a Completed badge for completed courses;
 * display a cropped image for channel image card in order to avoid blank lines
   around image not having the right aspect ratio;
 * use standard qweb widgets, notably float_time;
 * make header and footer of /slides and /slides/all editable and improve
   their styling;
 * remove old and unused css linked to previous versions of homepage;
 * various small code cleaning;

Commit linked to task ID 1941250 and PR odoo#31279.

Co-Authored-By: Thibault Delavallée <tde@odoo.com>
Co-Authored-By: Stefano Rigano <sri@odoo.com>

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[IMP] website_slides: improve homepage navbar design
Force white background + add the default bootstrap shadow. Do not use <h4>
tags to keep the right font-size on mobile. Simplify layout, add a second
navabar to handle content supposed to be moved to the right.

Commit linked to task ID 1941250 and PR odoo#31279.

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[IMP] website_slides: do not display channel information and featured…
… slide if search

Commit linked to task ID 1941250 and PR odoo#31279.

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[FIX] website_slides: various fixes related to course page
 * remove useless slide management buttons. This commit removes the frontend
   edit/publish/unlink buttons on slide cards (for the 'document' channel view)
   as they were not handled on the backend side.
 * hide slide type filter for documentation channels. The slide type filter
   (including statistics) on the left side of the channel frontend view
   was only handled for channels of type 'documentation'. This commit hides
   the slide type stats/filters if the channel is not of type documentation.
 * display add content/section buttons based on user rights. Fixes two channel
   frontend issues with user rights management:

   * Users that have the right to upload (can_upload field) should have the
    "Add content" button available.
   * The "Add section" button should only be available to website_publisher
     accordingly to ACLs

Commit linked to task ID 1941250 and PR odoo#31279.

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[FIX] website_profile: always give access to user to his own profile
The main condition to be able to see a profile is that the user we want to
see the profile is website_published.
But if a new user sign up and wants to access his own profile, he must
get access to his own profile, even if he is (not yet) website_published.

Commit linked to task ID 1941250 and PR odoo#31279.

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Feb 21, 2019

[FIX] website_slides: add various design and UX fixes
- slidesChannelDropdownSort : dropdown items back to visible (was white on white)
- Featured lesson : change icon to bullhorn instead of + icon
- Pass certification fullscreen button : btn primary
- set max height to fullscreen content to 100% minus header
- Fix 'infographic' slide type image view
- change image for 'Furniture Technical Specifications' course
- fix fullscreen presentation mode: The condition to add the iframe that
  contains the presentation of the document was wrong and, so, never met.
  Those conditions are evaluated in javascript and not in python as it's part
  of t-name template linked to a javascript widget.

Commit linked to task ID 1941250 and PR odoo#31279.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[IMP] website_slides_*: update manifests
Commit linked to task ID 1941250 and PR #31279.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides_survey: put the demo certification into a category
This commit puts the certification slide from the demo data into a category
so that it's correctly displayed on the channel frontend view.

Commit linked to task ID 1941250 and PR #31279.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[IMP] website_slides: fix and improve homepage
Various fixes linked to homepage of courses

 * move channel navigation in its right container, clean its display and
   related templating;
 * display a Completed badge for completed courses;
 * display a cropped image for channel image card in order to avoid blank lines
   around image not having the right aspect ratio;
 * use standard qweb widgets, notably float_time;
 * make header and footer of /slides and /slides/all editable and improve
   their styling;
 * remove old and unused css linked to previous versions of homepage;
 * various small code cleaning;

Commit linked to task ID 1941250 and PR #31279.

Co-Authored-By: Thibault Delavallée <tde@odoo.com>
Co-Authored-By: Stefano Rigano <sri@odoo.com>

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[IMP] website_slides: improve homepage navbar design
Force white background + add the default bootstrap shadow. Do not use <h4>
tags to keep the right font-size on mobile. Simplify layout, add a second
navabar to handle content supposed to be moved to the right.

Commit linked to task ID 1941250 and PR #31279.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[IMP] website_slides: do not display channel information and featured…
… slide if search

Commit linked to task ID 1941250 and PR #31279.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides: various fixes related to course page
 * remove useless slide management buttons. This commit removes the frontend
   edit/publish/unlink buttons on slide cards (for the 'document' channel view)
   as they were not handled on the backend side.
 * hide slide type filter for documentation channels. The slide type filter
   (including statistics) on the left side of the channel frontend view
   was only handled for channels of type 'documentation'. This commit hides
   the slide type stats/filters if the channel is not of type documentation.
 * display add content/section buttons based on user rights. Fixes two channel
   frontend issues with user rights management:

   * Users that have the right to upload (can_upload field) should have the
    "Add content" button available.
   * The "Add section" button should only be available to website_publisher
     accordingly to ACLs

Commit linked to task ID 1941250 and PR #31279.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_profile: always give access to user to his own profile
The main condition to be able to see a profile is that the user we want to
see the profile is website_published.
But if a new user sign up and wants to access his own profile, he must
get access to his own profile, even if he is (not yet) website_published.

Commit linked to task ID 1941250 and PR #31279.

robodoo pushed a commit that referenced this pull request Feb 21, 2019

[FIX] website_slides: add various design and UX fixes
- slidesChannelDropdownSort : dropdown items back to visible (was white on white)
- Featured lesson : change icon to bullhorn instead of + icon
- Pass certification fullscreen button : btn primary
- set max height to fullscreen content to 100% minus header
- Fix 'infographic' slide type image view
- change image for 'Furniture Technical Specifications' course
- fix fullscreen presentation mode: The condition to add the iframe that
  contains the presentation of the document was wrong and, so, never met.
  Those conditions are evaluated in javascript and not in python as it's part
  of t-name template linked to a javascript widget.

Commit linked to task ID 1941250 and PR #31279.

robodoo added a commit that referenced this pull request Feb 21, 2019

[MERGE] website_slides: various fixes for frontend and first design t…
…weaks

Purpose of this merge is to provide several fixes related to new elearning
application. Those are mainly fixes for front-end templates and first
design improvements / fixes.

See sub commits for more details.

Merge linked to task ID 1941250 and PR #31279.

closes #31306
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor Author

tde-banana-odoo commented Feb 21, 2019

Done at 5cec06b with #31306 .

@tde-banana-odoo tde-banana-odoo deleted the odoo-dev:saas-12.2-elearning-fiximp-tde-2 branch Feb 21, 2019

@robodoo robodoo added closed 💔 and removed r+ 👌 labels Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.