New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MERGE] website_slides: various fixes for frontend and first design tweaks #31279
Closed
tde-banana-odoo
wants to merge
9
commits into
odoo:saas-12.2
from
odoo-dev:saas-12.2-elearning-fiximp-tde-2
Closed
[MERGE] website_slides: various fixes for frontend and first design tweaks #31279
tde-banana-odoo
wants to merge
9
commits into
odoo:saas-12.2
from
odoo-dev:saas-12.2-elearning-fiximp-tde-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tde-banana-odoo
force-pushed
the
saas-12.2-elearning-fiximp-tde-2
branch
6 times, most recently
from
February 20, 2019 16:36
2b5fd4b
to
caa58f2
Compare
Commit linked to task ID 1941250 and PR odoo#31279.
Commit linked to task ID 1941250 and PR odoo#31279.
This commit puts the certification slide from the demo data into a category so that it's correctly displayed on the channel frontend view. Commit linked to task ID 1941250 and PR odoo#31279.
Various fixes linked to homepage of courses * move channel navigation in its right container, clean its display and related templating; * display a Completed badge for completed courses; * display a cropped image for channel image card in order to avoid blank lines around image not having the right aspect ratio; * use standard qweb widgets, notably float_time; * make header and footer of /slides and /slides/all editable and improve their styling; * remove old and unused css linked to previous versions of homepage; * various small code cleaning; Commit linked to task ID 1941250 and PR odoo#31279. Co-Authored-By: Thibault Delavallée <tde@odoo.com> Co-Authored-By: Stefano Rigano <sri@odoo.com>
Force white background + add the default bootstrap shadow. Do not use <h4> tags to keep the right font-size on mobile. Simplify layout, add a second navabar to handle content supposed to be moved to the right. Commit linked to task ID 1941250 and PR odoo#31279.
… slide if search Commit linked to task ID 1941250 and PR odoo#31279.
* remove useless slide management buttons. This commit removes the frontend edit/publish/unlink buttons on slide cards (for the 'document' channel view) as they were not handled on the backend side. * hide slide type filter for documentation channels. The slide type filter (including statistics) on the left side of the channel frontend view was only handled for channels of type 'documentation'. This commit hides the slide type stats/filters if the channel is not of type documentation. * display add content/section buttons based on user rights. Fixes two channel frontend issues with user rights management: * Users that have the right to upload (can_upload field) should have the "Add content" button available. * The "Add section" button should only be available to website_publisher accordingly to ACLs Commit linked to task ID 1941250 and PR odoo#31279.
The main condition to be able to see a profile is that the user we want to see the profile is website_published. But if a new user sign up and wants to access his own profile, he must get access to his own profile, even if he is (not yet) website_published. Commit linked to task ID 1941250 and PR odoo#31279.
- slidesChannelDropdownSort : dropdown items back to visible (was white on white) - Featured lesson : change icon to bullhorn instead of + icon - Pass certification fullscreen button : btn primary - set max height to fullscreen content to 100% minus header - Fix 'infographic' slide type image view - change image for 'Furniture Technical Specifications' course - fix fullscreen presentation mode: The condition to add the iframe that contains the presentation of the document was wrong and, so, never met. Those conditions are evaluated in javascript and not in python as it's part of t-name template linked to a javascript widget. Commit linked to task ID 1941250 and PR odoo#31279.
tde-banana-odoo
force-pushed
the
saas-12.2-elearning-fiximp-tde-2
branch
from
February 20, 2019 16:50
8afe2ec
to
e8a609e
Compare
tde-banana-odoo
changed the title
[MERGE] website_slides: do stuff
[MERGE] website_slides: various fixes for frontend and first design tweaks
Feb 20, 2019
@robodoo r+ rebase-merge |
Merge method set to rebase and merge, using the PR as merge commit message |
awa-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 21, 2019
Commit linked to task ID 1941250 and PR odoo#31279.
awa-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 21, 2019
This commit puts the certification slide from the demo data into a category so that it's correctly displayed on the channel frontend view. Commit linked to task ID 1941250 and PR odoo#31279.
awa-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 21, 2019
Various fixes linked to homepage of courses * move channel navigation in its right container, clean its display and related templating; * display a Completed badge for completed courses; * display a cropped image for channel image card in order to avoid blank lines around image not having the right aspect ratio; * use standard qweb widgets, notably float_time; * make header and footer of /slides and /slides/all editable and improve their styling; * remove old and unused css linked to previous versions of homepage; * various small code cleaning; Commit linked to task ID 1941250 and PR odoo#31279. Co-Authored-By: Thibault Delavallée <tde@odoo.com> Co-Authored-By: Stefano Rigano <sri@odoo.com>
awa-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 21, 2019
Force white background + add the default bootstrap shadow. Do not use <h4> tags to keep the right font-size on mobile. Simplify layout, add a second navabar to handle content supposed to be moved to the right. Commit linked to task ID 1941250 and PR odoo#31279.
awa-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 21, 2019
… slide if search Commit linked to task ID 1941250 and PR odoo#31279.
awa-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 21, 2019
* remove useless slide management buttons. This commit removes the frontend edit/publish/unlink buttons on slide cards (for the 'document' channel view) as they were not handled on the backend side. * hide slide type filter for documentation channels. The slide type filter (including statistics) on the left side of the channel frontend view was only handled for channels of type 'documentation'. This commit hides the slide type stats/filters if the channel is not of type documentation. * display add content/section buttons based on user rights. Fixes two channel frontend issues with user rights management: * Users that have the right to upload (can_upload field) should have the "Add content" button available. * The "Add section" button should only be available to website_publisher accordingly to ACLs Commit linked to task ID 1941250 and PR odoo#31279.
awa-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 21, 2019
The main condition to be able to see a profile is that the user we want to see the profile is website_published. But if a new user sign up and wants to access his own profile, he must get access to his own profile, even if he is (not yet) website_published. Commit linked to task ID 1941250 and PR odoo#31279.
awa-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 21, 2019
- slidesChannelDropdownSort : dropdown items back to visible (was white on white) - Featured lesson : change icon to bullhorn instead of + icon - Pass certification fullscreen button : btn primary - set max height to fullscreen content to 100% minus header - Fix 'infographic' slide type image view - change image for 'Furniture Technical Specifications' course - fix fullscreen presentation mode: The condition to add the iframe that contains the presentation of the document was wrong and, so, never met. Those conditions are evaluated in javascript and not in python as it's part of t-name template linked to a javascript widget. Commit linked to task ID 1941250 and PR odoo#31279.
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2019
Commit linked to task ID 1941250 and PR #31279.
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2019
This commit puts the certification slide from the demo data into a category so that it's correctly displayed on the channel frontend view. Commit linked to task ID 1941250 and PR #31279.
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2019
Various fixes linked to homepage of courses * move channel navigation in its right container, clean its display and related templating; * display a Completed badge for completed courses; * display a cropped image for channel image card in order to avoid blank lines around image not having the right aspect ratio; * use standard qweb widgets, notably float_time; * make header and footer of /slides and /slides/all editable and improve their styling; * remove old and unused css linked to previous versions of homepage; * various small code cleaning; Commit linked to task ID 1941250 and PR #31279. Co-Authored-By: Thibault Delavallée <tde@odoo.com> Co-Authored-By: Stefano Rigano <sri@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2019
Force white background + add the default bootstrap shadow. Do not use <h4> tags to keep the right font-size on mobile. Simplify layout, add a second navabar to handle content supposed to be moved to the right. Commit linked to task ID 1941250 and PR #31279.
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2019
… slide if search Commit linked to task ID 1941250 and PR #31279.
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2019
* remove useless slide management buttons. This commit removes the frontend edit/publish/unlink buttons on slide cards (for the 'document' channel view) as they were not handled on the backend side. * hide slide type filter for documentation channels. The slide type filter (including statistics) on the left side of the channel frontend view was only handled for channels of type 'documentation'. This commit hides the slide type stats/filters if the channel is not of type documentation. * display add content/section buttons based on user rights. Fixes two channel frontend issues with user rights management: * Users that have the right to upload (can_upload field) should have the "Add content" button available. * The "Add section" button should only be available to website_publisher accordingly to ACLs Commit linked to task ID 1941250 and PR #31279.
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2019
The main condition to be able to see a profile is that the user we want to see the profile is website_published. But if a new user sign up and wants to access his own profile, he must get access to his own profile, even if he is (not yet) website_published. Commit linked to task ID 1941250 and PR #31279.
robodoo
pushed a commit
that referenced
this pull request
Feb 21, 2019
- slidesChannelDropdownSort : dropdown items back to visible (was white on white) - Featured lesson : change icon to bullhorn instead of + icon - Pass certification fullscreen button : btn primary - set max height to fullscreen content to 100% minus header - Fix 'infographic' slide type image view - change image for 'Furniture Technical Specifications' course - fix fullscreen presentation mode: The condition to add the iframe that contains the presentation of the document was wrong and, so, never met. Those conditions are evaluated in javascript and not in python as it's part of t-name template linked to a javascript widget. Commit linked to task ID 1941250 and PR #31279.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this merge is to provide several fixes related to new elearning
application. Those are mainly fixes for front-end templates and first
design improvements / fixes.
See sub commits for more details.
Merge linked to task ID 1941250 and PR #31279.