Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master ccavenue yti #31281

Closed
wants to merge 1 commit into
base: saas-12.2
from

Conversation

Projects
None yet
4 participants
@tivisse
Copy link
Contributor

tivisse commented Feb 20, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@tivisse tivisse changed the base branch from 12.0 to saas-12.2 Feb 20, 2019

@robodoo robodoo added the seen 🙂 label Feb 20, 2019

@tivisse tivisse force-pushed the odoo-dev:master-ccavenue-yti branch Feb 20, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor Author

tivisse commented Feb 20, 2019

@C3POdoo C3POdoo added the RD label Feb 20, 2019

addons/payment_ccavenue/models/payment.py Outdated
backend = default_backend()
key = md5(self.ccavenue_working_key.encode('utf-8')).digest()
iv = os.urandom(16)
plaintext = self._ccavenue_pad(plaintext).encode('utf-8')

This comment has been minimized.

@mart-e

mart-e Feb 20, 2019

Contributor

is the padding still required?

@robodoo robodoo added the CI 🤖 label Feb 20, 2019

Revert "[ADD] payment_ccavenue: Add new payment acquirer for India"
This reverts commit f735951.

Revert payment acquire due to the fact that the encryption scheme
is broken by design and therefore cannot be trusted.

@tivisse tivisse force-pushed the odoo-dev:master-ccavenue-yti branch to 3e8a86d Feb 20, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor Author

tivisse commented Feb 20, 2019

@robodoo robodoo added r+ 👌 CI 🤖 and removed CI 🤖 labels Feb 20, 2019

robodoo pushed a commit that referenced this pull request Feb 20, 2019

Revert "[ADD] payment_ccavenue: Add new payment acquirer for India"
This reverts commit f735951.

Revert payment acquire due to the fact that the encryption scheme
is broken by design and therefore cannot be trusted.

closes #31281
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 20, 2019

@tivisse tivisse deleted the odoo-dev:master-ccavenue-yti branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.