Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] website_slides: refactor JS files (category/side bar/archiving/progress bar) #31283

Closed
wants to merge 4 commits into
base: saas-12.2
from

Conversation

Projects
None yet
3 participants
@awa-odoo
Copy link
Contributor

awa-odoo commented Feb 20, 2019

Purpose

This commits refactors the way slide.category are added on frontend:

  • JS now extends a standard Dialog widget
  • Added "required" name value on the form and handled validation
  • The controller adds the category at the bottom of the list (sequence+1)

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 20, 2019

@awa-odoo awa-odoo added the RD label Feb 20, 2019

@robodoo robodoo added the CI 🤖 label Feb 20, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:12.2-elearning-js-ref-awa branch Feb 21, 2019

@robodoo robodoo removed the CI 🤖 label Feb 21, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:12.2-elearning-js-ref-awa branch Feb 21, 2019

@robodoo robodoo added the CI 🤖 label Feb 21, 2019

@awa-odoo awa-odoo force-pushed the odoo-dev:12.2-elearning-js-ref-awa branch Feb 25, 2019

@robodoo robodoo removed the CI 🤖 label Feb 25, 2019

awa-odoo added some commits Feb 20, 2019

[REF] website_slides: refactor the slide.category modal on frontend
Purpose
=======

This commits refactors the way slide.category are added on frontend:

- JS now extends a standard Dialog widget
- Added "required" name value on the form and handled validation
- The controller adds the category at the bottom of the list (sequence+1)
[REF] website_slides: refactor the slide progress bar widget
Purpose
=======

This commit includes various improvement on the slides progress bar widget:

- linting
- better selectors (avoid global)
- doc
- "attachTo" instead of "appendTo"

More work is needed to include it correctly into other widgets using the progress bar
(see widget main comment for more detail).
[REF] website_slides: refactor the slide fullscreen side bar widget
Purpose
=======

This commit includes various improvement on the slides fullscreen side bar widget:

- linting
- better selectors (avoid global)
- "attachTo" instead of "appendTo"

@awa-odoo awa-odoo force-pushed the odoo-dev:12.2-elearning-js-ref-awa branch Feb 25, 2019

[REF] website_slides: refactor the slide archiving modal on frontend
Purpose
=======

This commits refactors the slide archiving confirmation modal to make it a standard
Dialog (remove global selectors, remove most of useless xml, ...).

It also adds a new slide archive route to allow channel publishers to archive slides in sudo mode.
(In ACLs only website_publishers can write slides).

@awa-odoo awa-odoo force-pushed the odoo-dev:12.2-elearning-js-ref-awa branch to 40b2fa4 Feb 25, 2019

@awa-odoo awa-odoo changed the title [REF] website_slides: refactor the slide.category modal on frontend [REF] website_slides: refactor JS files (category/side bar/archiving/progress bar) Feb 25, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

tde-banana-odoo commented Feb 25, 2019

Commit about category add and slide archive added in #31394 .

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

tde-banana-odoo commented Feb 25, 2019

[REF] website_slides: refactor the slide.category modal on frontend -> added in https://github.com/odoo/odoo/pull/31394/commits

[REF] website_slides: refactor the slide progress bar widget -> WIP by JEM

[REF] website_slides: refactor the slide fullscreen side bar widget -> done by QMO in https://github.com/odoo/odoo/pull/31394/commits

[REF] website_slides: refactor the slide archiving modal on frontend -> added in https://github.com/odoo/odoo/pull/31394/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.