Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website(_slides, *) : add various fixes in new elearning #31287

Closed
wants to merge 4 commits into
base: saas-12.2
from

Conversation

Projects
None yet
4 participants
@dbeguin
Copy link
Contributor

dbeguin commented Feb 20, 2019

No description provided.

@robodoo robodoo added the seen 🙂 label Feb 20, 2019

dbeguin added some commits Feb 20, 2019

[FIX] website_profile : give always access to user to his own profile
The main condition to be able to see a profile is that the user we want to
see the profile is website_published.
But if a new user sign up and wants to access his own profile, he must
get access to his own profile, even if he is (not yet) website_published.

Task ID : 1941250

Also linked with tasks :
1902304 : New eLearning Master Task
1922159 : website_profile (subtask)

PR #31287
[FIX] website_slides : add various design and UX fixes
- slidesChannelDropdownSort : dropdown items back to visible (was white on white)
- Featured lesson : change icon to bullhorn instead of + icon
- Pass certification fullscreen button : btn primary
- set max height to fullscreen content to 100% minus header
- Fix 'infographic' slide type image view
- change image for 'Furniture Technical Specifications' course

Task ID : 1941250
PR #
[FIX] website_slides : fix fullscreen presentation mode
The condition to add the iframe that contains the presentation of the document
was wrong and, so, never met.
Those conditions are evaluated in javascript and not in python as it's part of
t-name template linked to a javascript widget.

Task ID : 1941250
PR #

@dbeguin dbeguin force-pushed the odoo-dev:saas-12.2-elearning-fixes-dbe branch to dcae65a Feb 20, 2019

@C3POdoo C3POdoo added the RD label Feb 20, 2019

@robodoo robodoo added the CI 🤖 label Feb 20, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

tde-banana-odoo commented Feb 21, 2019

Everything has been included in 5cec06b . Thanks for your work !

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.