Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_payroll: Set benefit type on resource leave #31288

Closed
wants to merge 1 commit into
base: saas-12.2
from

Conversation

Projects
None yet
4 participants
@LucasLefevre
Copy link
Contributor

LucasLefevre commented Feb 20, 2019

Currently, when creating resource.calendar.leaves for a hr.leave it creates one in the employee's calendar and one in the contract's calendar if it's different.
But if both calendar are the same, it does not associate the benefit type to the resource leave.

This commit fixes the issue and add unit tests for this use case.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] hr_payroll: Set benefit type on resource leave
Currently, when creating `resource.calendar.leaves` for a
`hr.leave` it creates one in the employee's calendar and one
in the contract's calendar if it's different.
But if both calendar are the same, it does not associate
the benefit type to the resource leave.

This commit fixes the issue and add unit tests for this use
case.

@robodoo robodoo added the seen 🙂 label Feb 20, 2019

@LucasLefevre

This comment has been minimized.

Copy link
Contributor Author

LucasLefevre commented Feb 20, 2019

Dear @tivisse,
Could you take a look at this fix?
Thank you very much.
Have a nice day :)

@C3POdoo C3POdoo added the RD label Feb 20, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

tivisse commented Feb 20, 2019

robodoo pushed a commit that referenced this pull request Feb 20, 2019

[FIX] hr_payroll: Set benefit type on resource leave
Currently, when creating `resource.calendar.leaves` for a
`hr.leave` it creates one in the employee's calendar and one
in the contract's calendar if it's different.
But if both calendar are the same, it does not associate
the benefit type to the resource leave.

This commit fixes the issue and add unit tests for this use
case.

closes #31288
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 20, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.