Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account: currency of reconci. suggestion #31290

Closed
wants to merge 1 commit into
base: 12.0
from

Conversation

Projects
None yet
5 participants
@Julien00859
Copy link
Contributor

Julien00859 commented Feb 20, 2019

When the currency used for a payment/internal transfert is not the same
as the company currency, the prices shown in the reconciliation
suggestions are computed using the company currency.

  1. Enable multi-currency.
  2. Setup two bank, one in USD, the other in EUR.
  3. Leave the company currency to USD.
  4. Create an invoice for a partner targeting the EUR bank and
    validate it.
  5. Create a bank statement for the EUR bank amounting the exact
    value of the invoice for the same partner and reconcile it,
    this will create the payment behind the hood.
  6. In the reconciliation the invoice appears as suggestion, if the
    currency symbol is correct, the amount is shown as USD.

opw-1937202

closes #30623

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@Julien00859 Julien00859 requested a review from kebeclibre Feb 20, 2019

@robodoo robodoo added the seen 🙂 label Feb 20, 2019

@C3POdoo C3POdoo added the OE label Feb 20, 2019

@kebeclibre

This comment has been minimized.

Copy link
Contributor

kebeclibre commented Feb 20, 2019

"Je veux un test !"

@robodoo robodoo added the CI 🤖 label Feb 20, 2019

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

Julien00859 commented Feb 22, 2019

@Julien00859 Julien00859 changed the title [FIX] account: cur. of reconci. suggestion doesn't match the stmt cur. [FIX] account: currency of reconci. suggestion Feb 22, 2019

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

Julien00859 commented Feb 22, 2019

the current fix is invalid, do not take it into account

@csnauwaert

This comment has been minimized.

Copy link
Contributor

csnauwaert commented Feb 22, 2019

@Julien00859 Julien00859 force-pushed the odoo-dev:12.0-opw-1937202-bank_reconcile_multi_currency-juc branch Feb 22, 2019

@robodoo robodoo removed the CI 🤖 label Feb 22, 2019

@kebeclibre

This comment has been minimized.

Copy link
Contributor

kebeclibre commented Feb 22, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Feb 22, 2019

@Julien00859 Julien00859 force-pushed the odoo-dev:12.0-opw-1937202-bank_reconcile_multi_currency-juc branch Feb 22, 2019

@robodoo robodoo added CI 🤖 and removed r+ 👌 labels Feb 22, 2019

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

Julien00859 commented Feb 22, 2019

sudo -u @kebeclibre robodoo r+ 😛

@kebeclibre

This comment has been minimized.

Copy link
Contributor

kebeclibre commented Feb 22, 2019

robodoo r+

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 22, 2019

Staging failed: ci/runbot on 0b05f115ea2e8b4236462e9dd1fc9775f9bcb4b8 (view more at http://runbot.odoo.com/runbot/build/459600)

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

Julien00859 commented Feb 22, 2019

rebodoo retry

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

Julien00859 commented Feb 26, 2019

@kebeclibre can you r+ ?

[FIX] account: currency of reconci. suggestion
When the currency used for a payment/internal transfert is not the same
as the company currency, the prices shown in the reconciliation
suggestions are computed using the company currency.

1) Enable multi-currency.
2) Setup two bank, one in USD, the other in EUR.
3) Leave the company currency to USD.
4) Create an invoice for a partner targeting the EUR bank and
   validate it.
5) Create a bank statement for the EUR bank amounting the **exact**
   value of the invoice for the **same** partner and reconcile it,
   this will create the payment behind the hood.
6) In the reconciliation the invoice appears as suggestion, if the
   currency symbol is correct, the amount is shown as USD.

opw-1937202

closes #30623

@Julien00859 Julien00859 force-pushed the odoo-dev:12.0-opw-1937202-bank_reconcile_multi_currency-juc branch to f0ccbb8 Feb 26, 2019

@kebeclibre

This comment has been minimized.

Copy link
Contributor

kebeclibre commented Feb 26, 2019

robodoo r+

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 26, 2019

I'm sorry, @kebeclibre. This PR is already reviewed, reviewing it again is useless.

@kebeclibre

This comment has been minimized.

Copy link
Contributor

kebeclibre commented Feb 26, 2019

robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Feb 26, 2019

@robodoo robodoo closed this in 01405ca Feb 26, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Feb 26, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 26, 2019

Merged, thanks!

@Julien00859 Julien00859 deleted the odoo-dev:12.0-opw-1937202-bank_reconcile_multi_currency-juc branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.